Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No waterfall support for filterbank files #67

Open
MilesCranmer opened this issue Jul 2, 2016 · 1 comment
Open

No waterfall support for filterbank files #67

MilesCranmer opened this issue Jul 2, 2016 · 1 comment

Comments

@MilesCranmer
Copy link

MilesCranmer commented Jul 2, 2016

Some problems come up when you try to read a filterbank file into waterfaller.py. It does not seem as though there is support for the format, despite the description on the file preamble (e.g., it isn't even possible to get past the if statement from line 281 onwards ).

I can add support on my fork and then submit a pull request.
Should I wait for Chitrang's pull request to be finalized before working on this?

@MilesCranmer
Copy link
Author

Oops, I just read #65. @pscholz have you started to work on the filterbank support yet? I have some code that I wrote for a different software (includes filterbank support) that I can reconfigure to what you have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant