Add CLI option to override shell used #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As noted in saschagrunert#117, we want to override the shell that's used. In the case that we want to override the shell, we unfortunately run into the fact that `Ensure` requires `bash`. We can start by defaulting to using `sh`, which should be fairly safe as a drop-in.
saschagrunert
approved these changes
Sep 26, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #118 +/- ##
==========================================
+ Coverage 71.86% 72.80% +0.94%
==========================================
Files 3 3
Lines 231 239 +8
==========================================
+ Hits 166 174 +8
Misses 41 41
Partials 24 24 |
|
Thank you! The lint CI is not happy unfortunately. |
jamietanna
force-pushed
the
feature/shell
branch
2 times, most recently
from
d1092e2 to
3d0d038
Compare
jamietanna
force-pushed
the
feature/shell
branch
from
3d0d038 to
beb0dde
Compare
saschagrunert
approved these changes
Oct 20, 2023
jamietanna
force-pushed
the
feature/shell
branch
from
beb0dde to
0204af2
Compare
|
The linter now complains about the line length 🙃 |
|
Sorry yeah just trying to sort - unfortunately my local Go version isn't compatible with I'm trying to use a Docker container in the meantime! |
As noted in saschagrunert#117, we want to override the shell that's used. To do so, we can continue using the default of `bash`, but allow overriding it with the `--shell` flag. We need to disable the gosec finding for the new shell argument: G204: Subprocess launched with a potential tainted input or cmd arguments (gosec) As we're comfortable with the risk, as it runs on the user's machine. Closes saschagrunert#117.
jamietanna
force-pushed
the
feature/shell
branch
from
0204af2 to
0de93d7
Compare
|
Thank you 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
shforEnsureCloses #117.