Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email DetailView template not rendering #592

Open
OGRoomService opened this issue Jan 16, 2025 · 1 comment
Open

Email DetailView template not rendering #592

OGRoomService opened this issue Jan 16, 2025 · 1 comment
Labels
Area: Emails Issues & PRs related to all things regarding emails & email module Priority:Important Issues & PRs that are important; broken functions; errors; there are workarounds Severity: Major Significant impact/severe disruption Type: Bug Something isn't working Type:Duplicate Issues & PRs which are a duplicate of an existing issue/PR

Comments

@OGRoomService
Copy link

OGRoomService commented Jan 16, 2025

Issue

When attempting to go into DetailView for an email, it will not render if parent_type is null or an empty string in the database. Given that this is a possible state of the data within the database, there should be a null check to determine whether or not that part of the template should render, instead of blindly rendering it.

Possible Fix

Add a null check to the template to prevent

Steps to Reproduce the Issue

  1. Have an email in the database with parent_type set to null, or an empty string.
  2. Attempt to view that email record http://localhost:8080/#/emails/record/<id>
  3. View a blank page

Context

No response

Version

8.7.0

What browser are you currently using?

Firefox

Browser Version

No response

Environment Information

MariaDB-11.4.4, PHP-8.1.30

Operating System and Version

Debian GNU/Linux 12 (bookworm)

@OGRoomService OGRoomService added the Type: Bug Something isn't working label Jan 16, 2025
@johnM2401 johnM2401 added Type:Duplicate Issues & PRs which are a duplicate of an existing issue/PR Area: Emails Issues & PRs related to all things regarding emails & email module Priority:Important Issues & PRs that are important; broken functions; errors; there are workarounds Severity: Major Significant impact/severe disruption labels Jan 20, 2025
@johnM2401
Copy link

Hey! Thank you for raising this.
For reference, I think this is a likely duplicate of: #537 , so marking as such.
(Though please let me know if you feel otherwise)
Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Emails Issues & PRs related to all things regarding emails & email module Priority:Important Issues & PRs that are important; broken functions; errors; there are workarounds Severity: Major Significant impact/severe disruption Type: Bug Something isn't working Type:Duplicate Issues & PRs which are a duplicate of an existing issue/PR
Projects
None yet
Development

No branches or pull requests

2 participants