-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename upload/directory to upload/app #23
Comments
hello pcfreak30, If the function behind "s5/upload/directory" doesn't change because I also upload directories. and there are images from "1.jpg" to "100.jpg", which I can then access using cid and path to image. Whether it's called "s5/upload/directory" or "s5/upload/app" doesn't matter. |
If you want to use that endpoint to create a public directory, it does. Based on common sense, the name doesn't match the purpose/intent. |
@pcfreak30 how would you feel about |
@redsolver That works. Just need to keep these distinct. Can add more endpoints as needed in the future too, like /media. |
Given directory support is being/has been built,
s5/upload/directory
no longer makes sense for an app.It should be
s5/upload/app
.The text was updated successfully, but these errors were encountered: