Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Lines" parameter bugged in IE9 #39

Open
ghost opened this issue Oct 24, 2013 · 5 comments
Open

"Lines" parameter bugged in IE9 #39

ghost opened this issue Oct 24, 2013 · 5 comments

Comments

@ghost
Copy link

ghost commented Oct 24, 2013

I'm doing a simple
$(element).trunk8({ lines: 2 })
Which works great on mosts browsers.

However, in IE9 (did not test other versions of IE). It gets truncated at the end of the first line. Doing the same things with lines: 3 cuts it at the end of the second line, etc...

Had a quick look, the only difference I noticed is that on line 137, when we do
line_height = utils.getLineHeight(this) * settings.lines
the result of utils.getLineHeight(this) is different (21 on IE, 20 on Chrome).

This is most likely a display difference though, and I can't picture this would be the cause of the bug.
Any ideas?

@rviscomi
Copy link
Owner

Could you reproduce this on jsFiddle or some other site you can send me the source code? I'd like to try an debug it.

@ghost
Copy link
Author

ghost commented Oct 25, 2013

We're about to push on update on our website that will contain this trunk8 feature, as it's not critical. I'll let you know when we do and give you a link where the issue happens. (has it's full Front End, the debugger tools should suffice).
If I find some time before that I'll have a quick stab at it.

@ghost
Copy link
Author

ghost commented Nov 5, 2013

If you still want to have a look at it, here is the place where you can reproduce it:

  • Go to www.thredup.com/shop/women
  • Try $("#item-subset .info .item-title").trunk8({lines: 2}). This will truncate the titles of the items below the "Editor's Picks" to 2 lines in Chrome (as expected), but to 1 in IE. 3 lines will truncate to 2 lines in IE like explained in the first post.

Let me know if I can be of any help

@rviscomi
Copy link
Owner

rviscomi commented Nov 6, 2013

Sorry, hard to debug when the JS is minified. Is there a jsfiddle or similar that you could post?

@graingert
Copy link

IE9 and IE10 are now EOL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants