Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shall wasm32-wasi-related messages be improved? #4099

Open
vi opened this issue Nov 25, 2024 · 3 comments
Open

Shall wasm32-wasi-related messages be improved? #4099

vi opened this issue Nov 25, 2024 · 3 comments
Milestone

Comments

@vi
Copy link

vi commented Nov 25, 2024

Problem you are trying to solve

$ rustup update nightly
info: syncing channel updates for 'nightly-x86_64-unknown-linux-gnu'
info: latest update on 2024-11-25, rust version 1.85.0-nightly (28fc2ba71 2024-11-24)
info: skipping nightly which is missing installed component 'rust-std-wasm32-wasi'
info: syncing channel updates for 'nightly-2024-11-24-x86_64-unknown-linux-gnu'
info: syncing channel updates for 'nightly-2024-11-23-x86_64-unknown-linux-gnu'
info: latest update on 2024-11-23, rust version 1.85.0-nightly (a47555110 2024-11-22)
info: skipping nightly which is missing installed component 'rust-std-wasm32-wasi'
...

Nightly update falls back (probably because of WASI target changes).

Solution you'd like

Shall rustup include a helpful message for wasm32-wasi specifically, mentioning that now one should write wasm32-wasip1?

Or maybe even automatically migrate to it.

Notes

No response

@vi vi added the enhancement label Nov 25, 2024
@rami3l
Copy link
Member

rami3l commented Nov 29, 2024

@vi Thanks for filing this issue!

I think it's a bit dangerous to hardcode anything from our side, but given the repeated requests (which led to patches like #3453 and #3920), maybe we could borrow from Homebrew the "caveats" section which is controlled by the release server instead?

@rami3l rami3l added this to the On Deck milestone Dec 18, 2024
@ngoldbaum
Copy link

I just hit this today now that the change to wasm32-wasip1 stabilized in rust 1.84. If anyone is finding this thread and just wants a fix, you can do

rustup target remove wasm32-wasi
rustup update
rustup target add wasm32-wasip1

I agree that it would be nice to have an explicit helpful message containing something like these steps.

@rami3l
Copy link
Member

rami3l commented Jan 10, 2025

@ngoldbaum It should be noted though, if I were to directly add this note in Rustup today, it will not be delivered to the users in time, since we expect to release about once or twice a year, and the upstream is changing really fast (one stable release per 6 weeks).

Fortunately, our next release v1.28.0 (try the beta now!) will include #3920, which is essentially some sort of a mitigation to the underlying issue: the new version of the "component missing" notes now contains a link to this notice, which can be updated in time.

That said, I should have updated that notice by now... Thanks for the ping :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants