TravelAround cop does not detect around block when the block is passed as a proc using

[aki77]

The RuboCop::Cop::RSpecRails::TravelAround cop does not detect the following pattern:

around do |example|
  freeze_time(&example)
end

Expected behavior

The cop should detect and flag this pattern as it involves freezing time within the around block.

Actual behavior

The cop does not detect this pattern, leading to a potential inconsistency in time-travel-related detection.

[r7kamura]

I didn't know about this proc style usage until now, but it is certainly mentioned in the rspec-core comments, and it seems to be a legitimate usecase.

• https://github.com/rspec/rspec-core/blob/533ee6b0b6b6b3823be0a96f7ce7e0b3af2fe459/lib/rspec/core/hooks.rb#L332-L338

[r7kamura]

It seems like it could be handled just by changing this part, but it would be a bit more tedious to try to verify the exact correspondence of the example variable.

rubocop-rspec_rails/lib/rubocop/cop/rspec_rails/travel_around.rb

Lines 37 to 44 in 41a3bd4

	# @!method extract_run_in_travel(node)
	def_node_matcher :extract_run_in_travel, <<~PATTERN
	(block
	$(send nil? TRAVEL_METHOD_NAMES ...)
	(args ...)
	(send _ :run)
	)
	PATTERN

[r7kamura]

around do |example|
  freeze_time(&example)
end

Since the above code is interpreted as follows,

(block
  (send nil :around)
  (args
    (procarg0
      (arg :example)))
  (send nil :freeze_time
    (block-pass
      (lvar :example))))

It would be good to change the (send _ :run) part to also support (block-pass (lvar _))?