drop min_confidence
#162
Comments
dpprdan
added a commit
that referenced
this issue
Dec 26, 2024
Merged
dpprdan
added a commit
that referenced
this issue
Jan 13, 2025
* use examples from Brest instead of Nantes, because some examples don't work anymore, cf. #160 * remove tests w.r.t. `min_confidence`, cf. #161, #162 * update {Roxygen} version * add ProjectId * update snapshots, presumably due to changes in {testthat} * make lintr happy * remove more tests w.r.t. `min_confidence` * some minor fixes, e.g. `q=Berlin, limit=5` returns only one result, making that example useless. also the hotel de ville in Nantes example isn't working anymore, see #160 * pre-compile vignettes and README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
OpenCage (the API) has dropped support for
min_confidence(the parameter kind of still works, but not always reliably, e.g. #161).I am leaning towards removing all code w.r.t.
min_confidenceand to just issue a warning that the parameter is not supported anymore. There is not much use passing it through to the API if the results aren't reliable. Also it apparently hasn't been used much in practice and was often misunderstood anyways.The text was updated successfully, but these errors were encountered: