Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create integration test for command-line tools #552

Open
gavv opened this issue Sep 22, 2023 · 4 comments
Open

Create integration test for command-line tools #552

gavv opened this issue Sep 22, 2023 · 4 comments
Labels
easy hacks The solution is expected to be straightforward even if you are new to the project help wanted An important and awaited task but we have no human resources for it yet much-needed This issue is needed most among other help-wanted issues rt-tests Real-time tests tests

Comments

@gavv
Copy link
Member

gavv commented Sep 22, 2023

It would be nice to add integration tests for our command-line tools: roc-send and roc-recv. Currently they are not covered with tests, and sometimes a breakage remains unnoticeable for a while.

These tests will live in a separate repo: rt-tests.

A test will basically generate a wav file, and run roc-send to send it and roc-recv to receive it and record to a new wav file, and then compare original and received files.

For further details please refer to the issue in rt-tests: roc-streaming/rt-tests#4

See also: #551.
@gavv gavv added tests help wanted An important and awaited task but we have no human resources for it yet rt-tests Real-time tests labels Sep 22, 2023
@gavv gavv added easy hacks The solution is expected to be straightforward even if you are new to the project much-needed This issue is needed most among other help-wanted issues labels Sep 22, 2023
@u7763283
Copy link

I'm interested in this. Can you assign it to me?

@gavv
Copy link
Member Author

gavv commented Oct 10, 2023

You're welcome!

@u7763283
Copy link

Hello, I have created a pull request in rt-test. Could you please take a look?

@u7763283 u7763283 mentioned this issue Oct 28, 2023
Open
@gavv gavv mentioned this issue Nov 23, 2023
Merged
@gavv
Copy link
Member Author

gavv commented Jun 20, 2024

@u7763283 Hi, do you still have plans on the issue?

@gavv gavv added this to Roc Toolkit Jul 6, 2024
@gavv gavv moved this to Help wanted in Roc Toolkit Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
easy hacks The solution is expected to be straightforward even if you are new to the project help wanted An important and awaited task but we have no human resources for it yet much-needed This issue is needed most among other help-wanted issues rt-tests Real-time tests tests
Projects
Roc Toolkit
Status: Help wanted
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gavv @u7763283