Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundancy: requirements.txt and setup.py #15

Open
dgahle opened this issue Jan 10, 2022 · 0 comments
Open

Redundancy: requirements.txt and setup.py #15

dgahle opened this issue Jan 10, 2022 · 0 comments

Comments

@dgahle
Copy link

dgahle commented Jan 10, 2022

Package installation using the setup.py checks for package dependencies required (pandas, six, python-pptx) and installs them if missing. Thus installing the same modules from requirements.txt is redundant.

requirements-tests.txt could be made redundant by adding {} to setup.py as well. Though I appreciate that you might want to keep these separate.

I would be happy to make the change and submit a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant