From 9098063249add8a253e4392608ed1ce04016a489 Mon Sep 17 00:00:00 2001
From: Matvii Zorin <matvii.zorin@globallogic.com>
Date: Wed, 25 Nov 2020 14:35:59 +0200
Subject: [PATCH] gralloc_gbm: Implement validateBufferSize() method

The method implementation is required for passing the ValidateBufferSizeBadValue
of GraphicsMapperHidlTest.

The minimal implementation ensures that the input parameters from
the mapper and the data accessed by the buffer handle are equal.

Signed-off-by: Matvii Zorin <matvii.zorin@globallogic.com>
---
 gralloc.cpp        | 16 +++++++++++++++-
 gralloc_gbm.cpp    | 45 +++++++++++++++++++++++++++++++++++++++++++++
 gralloc_gbm_priv.h |  3 +++
 3 files changed, 63 insertions(+), 1 deletion(-)

diff --git a/gralloc.cpp b/gralloc.cpp
index 1cc9f55..bc7728c 100644
--- a/gralloc.cpp
+++ b/gralloc.cpp
@@ -163,6 +163,19 @@ static int gbm_mod_lock_ycbcr(gralloc_module_t const *mod, buffer_handle_t handl
 	return err;
 }
 
+static int32_t gbm_mod_validate_buffer_size(const gralloc_module_t *mod,
+		buffer_handle_t handle, uint32_t w, uint32_t h, int32_t format, int usage, uint32_t stride)
+{
+	struct gbm_module_t *dmod = (struct gbm_module_t *) mod;
+	int err;
+
+	pthread_mutex_lock(&dmod->mutex);
+	err = gbm_validate_buffer_size(handle, w, h, format, usage, stride);
+	pthread_mutex_unlock(&dmod->mutex);
+
+	return err;
+}
+
 static int gbm_mod_close_gpu0(struct hw_device_t *dev)
 {
 	struct gbm_module_t *dmod = (struct gbm_module_t *)dev->module;
@@ -265,7 +278,8 @@ struct gbm_module_t HAL_MODULE_INFO_SYM = {
 		.lock = gbm_mod_lock,
 		.unlock = gbm_mod_unlock,
 		.lock_ycbcr = gbm_mod_lock_ycbcr,
-		.perform = gbm_mod_perform
+		.perform = gbm_mod_perform,
+		.validateBufferSize = gbm_mod_validate_buffer_size
 	},
 
 	.mutex = PTHREAD_MUTEX_INITIALIZER,
diff --git a/gralloc_gbm.cpp b/gralloc_gbm.cpp
index 29d11cd..c117b7d 100644
--- a/gralloc_gbm.cpp
+++ b/gralloc_gbm.cpp
@@ -529,3 +529,48 @@ int gralloc_gbm_bo_lock_ycbcr(buffer_handle_t handle,
 
 	return 0;
 }
+
+/*
+ * Validate that the buffer can be safely accessed by a caller who assumes
+ * the specified width, height, format, usage, and stride.
+ */
+int32_t gbm_validate_buffer_size(buffer_handle_t handle, uint32_t w, uint32_t h, int32_t format,
+		int usage, uint32_t stride)
+{
+	struct gralloc_handle_t *gbm_handle = gralloc_handle(handle);
+
+	if (!gbm_handle) {
+		ALOGE("buffer validation unsuccess, bad handle: %p", gbm_handle);
+		return -EINVAL;
+	}
+
+	if (w != gbm_handle->width) {
+		ALOGE("buffer validation unsuccess, specified width %d requires %d", w, gbm_handle->width);
+		return -ENOMEM;
+	}
+
+	if (h != gbm_handle->height) {
+		ALOGE("buffer validation unsuccess, specified height %d requires %d", h, gbm_handle->height);
+		return -ENOMEM;
+	}
+
+	if (format != gbm_handle->format) {
+		ALOGE("buffer validation unsuccess, specified format 0x%x requires 0x%x", format,
+				gbm_handle->format);
+		return -ENOMEM;
+	}
+
+	if (usage != gbm_handle->usage) {
+		ALOGE("buffer validation unsuccess, specified usage 0x%x requires 0x%x", usage,
+				gbm_handle->usage);
+		return -ENOMEM;
+	}
+
+	if (stride * gralloc_gbm_get_bpp(format) != gbm_handle->stride) {
+		ALOGE("buffer validation unsuccess, specified stride %d requires %d",
+				stride * gralloc_gbm_get_bpp(format), gbm_handle->stride);
+		return -ENOMEM;
+	}
+
+	return 0;
+}
diff --git a/gralloc_gbm_priv.h b/gralloc_gbm_priv.h
index cbe9256..1d7d115 100644
--- a/gralloc_gbm_priv.h
+++ b/gralloc_gbm_priv.h
@@ -48,6 +48,9 @@ int gralloc_gbm_bo_unlock(buffer_handle_t handle);
 int gralloc_gbm_bo_lock_ycbcr(buffer_handle_t handle, int usage,
 		int x, int y, int w, int h, struct android_ycbcr *ycbcr);
 
+int32_t gbm_validate_buffer_size(buffer_handle_t handle, uint32_t w, uint32_t h, int32_t format,
+		int usage, uint32_t stride);
+
 struct gbm_device *gbm_dev_create(void);
 void gbm_dev_destroy(struct gbm_device *gbm);