Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove CSharpGuidelinesAnalyzer #139

Closed
rjmurillo opened this issue Jul 5, 2024 · 0 comments · Fixed by #145
Closed

Remove CSharpGuidelinesAnalyzer #139

rjmurillo opened this issue Jul 5, 2024 · 0 comments · Fixed by #145
Labels
.NET Pull requests that update .net code triage
Milestone
v0.2.0

Comments

@rjmurillo
Copy link
Owner

The "AV" prefix of issues is more annoying than it is helpful
@rjmurillo rjmurillo added .NET Pull requests that update .net code triage labels Jul 5, 2024
@rjmurillo rjmurillo added this to the v0.2.0 milestone Jul 5, 2024
@rjmurillo rjmurillo mentioned this issue Jul 5, 2024
Merged
rjmurillo added a commit that referenced this issue Jul 6, 2024
@rjmurillo
Remove CSharpGuidelinesAnalyzer and associated editorconfig values
a4ae63e 
Fixes #139
@rjmurillo rjmurillo linked a pull request Jul 6, 2024 that will close this issue
Remove CSharpGuidelinesAnalyzer and associated editorconfig values #145
Merged
rjmurillo added a commit that referenced this issue Jul 14, 2024
@rjmurillo
Add Mock.Of<T> and MockRepository support to ConstructorArgumentsShou…
1d1533a 
…ldMatchAnalyzer (#140)

The majority of this change is mechanical (moving code from one location
to another, replacing magic strings with constants, etc.). There is a
functional update that completely changes the
`ConstructorArgumentsShouldMatchAnalyzer`:

- consolidating two constructor analyzers now into a single shared
source
- improving the performance of the constructor analyzer
- adding support for checking delegate
- adding support for `Mock.Of<T>` and `MockRepository` features of `Moq`


![image](https://github.com/rjmurillo/moq.analyzers/assets/6811113/cf6e2e52-237c-4f5e-bdc8-dadb0026eeba)
_Baseline is an empty analyzer, control is the old interface constructor
parameter analyzer, treatment is the new combined analyzer._

Changes

Misc:
- Reduced severity of AV analyzer items (see #139)
- Move magic strings to constants
- Moved much of the common code into a `Common` folder and namespace

Documentation:
- Fixed links to documentation for shipped analyzers
- In analyzer rule help, link to commit id so documentation snaps to the
version of the analyzer

Analyzers:
- Moved rule ID to constants file
- Added extension factory methods to help create `Diagnostic`
- Consolidated two constructor parameter analyzers (Moq1001 and Moq1002)
into a single analyzer with 30% better performance
- `ConstructorArgumentsShouldMatchAnalyzer` now supports `Mock.Of<T>`
syntax and `MockRepository` patterns

Benchmarks:
- Add the ability to have a control and treatment as well as "baseline",
allowing A/B performance benchmarking of implementations
- Added benchmark for `ConstructorArgumentsShouldMatchAnalyzer`

Test:
- Added extension methods to include all Moq versions under test or just
the latest
- Organized the `ConstructorArgumentsShouldMatchAnalyzer` test
collateral (it's the highest volume) into partial files
- Added Live Unit Test configuration when running in Visual Studio
- Added code coverage filter for benchmark code if using ReSharper or
Rider

_Note: while code coverage is improved, it's still below 95%. This is
due to some guard cases that need coverage. For example, #141_

Resolves #122
For Moq1001 and Moq1002, #85
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
.NET Pull requests that update .net code triage
Projects
None yet
Milestone
v0.2.0
Development

Successfully merging a pull request may close this issue.

Remove CSharpGuidelinesAnalyzer and associated editorconfig values rjmurillo/moq.analyzers
1 participant
@rjmurillo