From ac86356192fee5b8f7c1f669b399a3745df056dd Mon Sep 17 00:00:00 2001
From: Matt Kotsenas <Matt.Kotsenas@gmail.com>
Date: Mon, 25 Nov 2024 15:36:07 -0800
Subject: [PATCH] Move "upload binlogs" CI step earlier in pipeline and run
 even if failed (#273)

Currently, the "upload binlogs" step is too far down in the CI pipeline
(and also doesn't run if the build fails). Move it up a bit so that the
order of log upload mirrors the order of actions and add `success() ||
failure()` so they are uploaded even during build failures.
---
 .github/workflows/main.yml | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index 0e6bdf07..3a064848 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -66,6 +66,14 @@ jobs:
     - name: Test
       run: dotnet test --no-build --configuration Release --settings ./build/targets/tests/test.runsettings
 
+    - name: Upload binlogs
+      uses: actions/upload-artifact@v4
+      if: success() || failure()
+      with:
+        name: binlogs-${{ matrix.os }}
+        path: ./artifacts/logs
+        if-no-files-found: error
+
     - name: Upload *.received.* files
       uses: actions/upload-artifact@v4
       if: failure()
@@ -107,13 +115,6 @@ jobs:
         project-token: ${{ secrets.CODACY_PROJECT_TOKEN }}
         coverage-reports: ${{ github.workspace }}/artifacts/TestResults/coverage/Cobertura.xml
 
-    - name: Upload binlogs
-      uses: actions/upload-artifact@v4
-      with:
-        name: binlogs-${{ matrix.os }}
-        path: ./artifacts/logs
-        if-no-files-found: error
-
     - name: Upload packages
       uses: actions/upload-artifact@v4
       with: