Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verovio displaying from key signatures #3877

Open
Daniel63656 opened this issue Dec 5, 2024 · 6 comments
Open

Verovio displaying from key signatures #3877

Daniel63656 opened this issue Dec 5, 2024 · 6 comments
Labels

Comments

@Daniel63656
Copy link

Verovio renders wrong key signatures for the minimal musicxml example I attached.

It should look like this (rendered using musescore):
musescore
but verovio renders key signatures wrong for second part:
verovio

Here the musicxml to reproduce the behaviour:

<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE score-partwise PUBLIC "-//Recordare//DTD MusicXML 3.1 Partwise//EN" "http://www.musicxml.org/dtds/partwise.dtd">
<score-partwise version="3.1">
  <movement-title>Pop Medley</movement-title>
  <identification>
    <creator type="arranger">Arr. by </creator>
    <creator type="composer">Various Artists</creator>
    <creator type="lyricist">Various Lyricists</creator>
    <rights>Copyright © To Their Respective Owners / MuseScore
Arreglo / Score</rights>
    <encoding>
      <software>MuseScore 3.6.2</software>
      <encoding-date>2024-12-05</encoding-date>
      <supports element="accidental" type="yes"/>
      <supports element="beam" type="yes"/>
      <supports element="print" attribute="new-page" type="no"/>
      <supports element="print" attribute="new-system" type="no"/>
      <supports element="stem" type="yes"/>
      </encoding>
    <source>http://musescore.com/score/2454866</source>
    </identification>
  <defaults>
    <scaling>
      <millimeters>7.23192</millimeters>
      <tenths>40</tenths>
      </scaling>
    <page-layout>
      <page-height>1545</page-height>
      <page-width>1193.99</page-width>
      <page-margins type="both">
        <left-margin>139.999</left-margin>
        <right-margin>139.999</right-margin>
        <top-margin>69.9998</top-margin>
        <bottom-margin>69.9998</bottom-margin>
        </page-margins>
      </page-layout>
    <word-font font-family="Helvetica Neue" font-size="10.25"/>
    <lyric-font font-family="FreeSerif" font-size="11"/>
    </defaults>
  <credit page="1">
    <credit-type>rights</credit-type>
    <credit-words default-x="596.995" default-y="69.9998" justify="center" valign="bottom">Copyright © To Their Respective Owners / MuseScore
Arreglo / Score</credit-words>
    </credit>
  <part-list>
    <score-part id="P1">
      <part-name>Trompette en Si♭</part-name>
      <part-abbreviation>Tromp. Si♭</part-abbreviation>
      <score-instrument id="P1-I1">
        <instrument-name>Trompette en Si♭</instrument-name>
        </score-instrument>
      <midi-device id="P1-I1" port="1"></midi-device>
      <midi-instrument id="P1-I1">
        <midi-channel>1</midi-channel>
        <midi-program>57</midi-program>
        <volume>78.7402</volume>
        <pan>0</pan>
        </midi-instrument>
      </score-part>
    <score-part id="P2">
      <part-name>Piano</part-name>
      <part-abbreviation>Pno.</part-abbreviation>
      <score-instrument id="P2-I1">
        <instrument-name>SmartMusic SoftSynth</instrument-name>
        </score-instrument>
      <midi-device id="P2-I1" port="1"></midi-device>
      <midi-instrument id="P2-I1">
        <midi-channel>3</midi-channel>
        <midi-program>1</midi-program>
        <volume>79.5276</volume>
        <pan>-34</pan>
        </midi-instrument>
      </score-part>
    </part-list>
  <part id="P1">
    <measure number="1" width="246.16">
      <print>
        <system-layout>
          <system-margins>
            <left-margin>187.22</left-margin>
            <right-margin>0.00</right-margin>
            </system-margins>
          <top-system-distance>170.00</top-system-distance>
          </system-layout>
        </print>
      <attributes>
        <divisions>1</divisions>
        <key>
          <fifths>0</fifths>
          </key>
        <time>
          <beats>4</beats>
          <beat-type>4</beat-type>
          </time>
        <clef>
          <sign>G</sign>
          <line>2</line>
          </clef>
        <transpose>
          <diatonic>-1</diatonic>
          <chromatic>-2</chromatic>
          </transpose>
        </attributes>
      <note>
        <rest/>
        <duration>4</duration>
        <voice>1</voice>
        <type>whole</type>
        </note>
      </measure>
    <measure number="2" width="209.32">
      <attributes>
        <key>
          <fifths>6</fifths>
          </key>
        </attributes>
      <note>
        <rest measure="yes"/>
        <duration>4</duration>
        <voice>1</voice>
        </note>
      </measure>
    <measure number="3" width="154.76">
      <note>
        <rest measure="yes"/>
        <duration>4</duration>
        <voice>1</voice>
        </note>
      <barline location="right">
        <bar-style>light-light</bar-style>
        </barline>
      </measure>
    <measure number="4" width="186.53">
      <attributes>
        <key>
          <fifths>-1</fifths>
          </key>
        </attributes>
      <note>
        <rest measure="yes"/>
        <duration>4</duration>
        <voice>1</voice>
        </note>
      <barline location="right">
        <bar-style>light-heavy</bar-style>
        </barline>
      </measure>
    </part>
  <part id="P2">
    <measure number="1" width="246.16">
      <print>
        <staff-layout number="1">
          <staff-distance>65.00</staff-distance>
          </staff-layout>
        <staff-layout number="2">
          <staff-distance>65.00</staff-distance>
          </staff-layout>
        </print>
      <attributes>
        <divisions>1</divisions>
        <key>
          <fifths>-2</fifths>
          <mode>major</mode>
          </key>
        <time>
          <beats>4</beats>
          <beat-type>4</beat-type>
          </time>
        <staves>2</staves>
        <clef number="1">
          <sign>G</sign>
          <line>2</line>
          </clef>
        <clef number="2">
          <sign>F</sign>
          <line>4</line>
          </clef>
        </attributes>
      <note>
        <rest measure="yes"/>
        <duration>4</duration>
        <voice>1</voice>
        <staff>1</staff>
        </note>
      <backup>
        <duration>4</duration>
        </backup>
      <note>
        <rest measure="yes"/>
        <duration>4</duration>
        <voice>5</voice>
        <staff>2</staff>
        </note>
      </measure>
    <measure number="2" width="209.32">
      <attributes>
        <key>
          <fifths>4</fifths>
          <mode>major</mode>
          </key>
        </attributes>
      <note>
        <rest measure="yes"/>
        <duration>4</duration>
        <voice>1</voice>
        <staff>1</staff>
        </note>
      <backup>
        <duration>4</duration>
        </backup>
      <note>
        <rest measure="yes"/>
        <duration>4</duration>
        <voice>5</voice>
        <staff>2</staff>
        </note>
      </measure>
    <measure number="3" width="154.76">
      <note>
        <rest measure="yes"/>
        <duration>4</duration>
        <voice>1</voice>
        <staff>1</staff>
        </note>
      <backup>
        <duration>4</duration>
        </backup>
      <note>
        <rest measure="yes"/>
        <duration>4</duration>
        <voice>5</voice>
        <staff>2</staff>
        </note>
      <barline location="right">
        <bar-style>light-light</bar-style>
        </barline>
      </measure>
    <measure number="4" width="186.53">
      <attributes>
        <key>
          <fifths>-3</fifths>
          <mode>major</mode>
          </key>
        </attributes>
      <note>
        <rest/>
        <duration>4</duration>
        <voice>1</voice>
        <type>whole</type>
        <staff>1</staff>
        </note>
      <backup>
        <duration>4</duration>
        </backup>
      <note>
        <rest measure="yes"/>
        <duration>4</duration>
        <voice>5</voice>
        <staff>2</staff>
        </note>
      <barline location="right">
        <bar-style>light-heavy</bar-style>
        </barline>
      </measure>
    </part>
  </score-partwise>
@lpugin
Copy link
Contributor

lpugin commented Dec 5, 2024

The file does not import into Finale and Dorico. Is does import into MuseScore 4 (4.4.3). Exporting MusicXML from it or MEI both work properly with Verovio, so this it more looking like a bad data issue than a Verovio one.

@rettinghaus
Copy link
Contributor

Verovios MusicXML importer only takes key changes from the first staff into account.

@Daniel63656
Copy link
Author

First staff in part or in general?
Plans on fixing this?

@rettinghaus
Copy link
Contributor

In general. No plans right now to fix this. For now you should go with the proposed workarounds.

@Daniel63656
Copy link
Author

Ok. The same holds true for time signatures I guess?
But not clefs?

@rettinghaus
Copy link
Contributor

Clefs should work fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants