Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Verovio code #89

Open
ahankinson opened this issue May 23, 2024 · 1 comment
Open

Fix Verovio code #89

ahankinson opened this issue May 23, 2024 · 1 comment
Assignees
@ahankinson
Labels
Audience: RISM internal Issues that affect RISM staff Type: Spec Administration Changes to processes or external factors

Comments

@ahankinson
Copy link
Contributor

In the ties section of V2 the ties are illustrated with underscores (reflecting #1 ) but are given in the code section with + so that they display correctly. Once Verovio is updated to support underscores with ties, this should be fixed.

Left here as a reminder to fix this.
@ahankinson ahankinson self-assigned this May 23, 2024
@ahankinson ahankinson added Audience: RISM internal Issues that affect RISM staff Type: Spec Administration Changes to processes or external factors labels May 23, 2024
@ahankinson
Copy link
Contributor Author

Also the fermata and appogiatura groups are notated differently than the Verovio code.

ahankinson added a commit that referenced this issue May 29, 2024
@ahankinson
Fixed: Change appogiatura groups to y
028fed6 
Note that the Verovio code remains the same so that the examples render correctly. This will be addressed in #89.

Fixes #113
@ahankinson ahankinson mentioned this issue May 29, 2024
Closed
@lpugin lpugin mentioned this issue May 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ahankinson ahankinson

Labels
Audience: RISM internal Issues that affect RISM staff Type: Spec Administration Changes to processes or external factors
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ahankinson