Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build failure on new toolchain #58

Open
ivq opened this issue Nov 25, 2023 · 0 comments · May be fixed by #59
Open

Build failure on new toolchain #58

ivq opened this issue Nov 25, 2023 · 0 comments · May be fixed by #59

Comments

@ivq
Copy link

ivq commented Nov 25, 2023

At least current stable toolchain(1.74.0) is complaining:

error: assigning to `&T` is undefined behavior, consider using an `UnsafeCell`
   --> /home/user/gd32vf103xx-hal/src/serial.rs:422:17
    |
422 |                 ptr::write_volatile(&(*USART::ptr()).data as *const _ as *mut _, byte)
    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: for more information, visit <https://doc.rust-lang.org/book/ch15-05-interior-mutability.html>
    = note: `#[deny(invalid_reference_casting)]` on by default

This kind of compile errors seem start to exist in 1.73.0: rust-lang/rust#116410
@ivq ivq linked a pull request Nov 25, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix build error that assigning to &T is undefined behavior ivq/gd32vf103xx-hal
1 participant
@ivq