Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wheel package for python 3.12 not built #20

Open
astrandb opened this issue Apr 7, 2024 · 6 comments
Open

Wheel package for python 3.12 not built #20

astrandb opened this issue Apr 7, 2024 · 6 comments

Comments

@astrandb
Copy link

astrandb commented Apr 7, 2024

I am having problems starting devcontainers for Home Assistant. Startup fails many times due to very long (>3 minutes) load/build time of webrtc-noice-gain. I can get around this "crash" by doing pip install webrtc-noice-gain==1.2.3. It can still take a couple of minutes to complete this command, but it doesn't timeout. I can then restart HA in the devcontainer in more predictable way.

@bantu
Copy link

bantu commented Apr 21, 2024

You're probably seeing the issue reported at #16. This comment helped me: #16 (comment)

@oyvindwe
Copy link

oyvindwe commented Jul 7, 2024

I have a similar problem on macOS (my Home Assistant dev environment), which fails to build 1.2.4. If I downgrade to 1.2.3 I get a precompiled wheel.

@oyvindwe
Copy link

oyvindwe commented Jul 7, 2024

Ah, I see the wheel has changed from cp311-cp311-macosx_10_9_universal2.whl to cp312-cp312-macosx_14_0_arm64.whl, which i a bummer since I'm stuck on macOS 12.7.5.

Is it possible to add more wheels?

@synesthesiam
Copy link
Contributor

I don't have a Mac, so I'm only able to build with what Github offers (unless you know a way to build a universal where with Github actions).

@oyvindwe
Copy link

oyvindwe commented Jul 9, 2024

This should be possible by setting up a matrix with all the OS and Python versions that you want to build a wheel for.

There are some example configurations here: https://docs.github.com/en/actions/automating-builds-and-tests/building-and-testing-python

@oyvindwe
Copy link

I have submitted PR #25 to build more wheels, but there is something funky with the test action - it defines a matrix arch: [aarch64, armhf, armv7, amd64, i386], but it's not used in the action except to generate the job name. All the linux jobs build wheels for cp310-cp310-linux_x86_64 - see e.g. https://github.com/rhasspy/webrtc-noise-gain/actions/runs/9828382455

After cleaning up and adding Python 3.12, I've got GitHub to build wheels for:

  • cp311-cp311-macosx_10_9_universal2
  • cp312-cp312-macosx_10_9_universal2
  • cp312-cp312-macosx_14_0_arm64
  • cp311-cp311-linux_x86_64
  • cp312-cp312-linux_x86_64

I have not been able to figure out if GitHub can build for the other Linux architectures (aarch64, armhf, and armv7).

Do we want to still build Python 3.11 images?

Note that actions/create-release in the "Create release" job soon needs to be replaced as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants