Support compiling on Windows/msvc #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires
setuptools._distutils._msvccompilerto circumvent a "failed: None" error withlink.exe, which I assume is a cmd line length issue; as per the docs on the class, VS 2015 or later is required. The workaround I found is to override thespawnmethod and output the command params to a file, which is then passed tolink.exewith@. There might be a better way, but in the meantime, this works.Tested on Win11 with MS Build Tools 2022 (msvc 14.38.33130), Python (3.11 & 3.12); compiled, installed, and used without issue.
Unless I missed something, these changes shouldn't affect other build platforms at all.
Fixes #13