Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library Tag Exclusion not working #30

Open
mlamoure opened this issue Sep 1, 2023 · 5 comments
Open

Library Tag Exclusion not working #30

mlamoure opened this issue Sep 1, 2023 · 5 comments
Assignees

Comments

@mlamoure
Copy link

mlamoure commented Sep 1, 2023

I do not believe the tag exclusion is working for libraries, if I understand how it's supposed to work. I set up a tag in both Sonarr and Radarr for "never_expire" and added that to the Deleterr config. However a dry-run showed that it would have deleted several movies and shows that are tagged with this tag.

@rfsbraz
Copy link
Owner

rfsbraz commented Sep 1, 2023

Yeah I honestly expected this one to cause confusion. Every metadata aspect is checked against plex, I think tags are actually called labels there. But regardless these settings need to be clearer, and maybe more broad. I could do:

libraries:
  - name: "Movies"
    ...
    exclude:
      plex:
        titles: ["Forrest Gump"]
        tags: ["children", "favorite"]
        genres: ["horror", "thriller"]
        collections: ["Marvel Cinematic Universe"]
        actors: ["Tom Cruise", "Brad Pitt"]
        producers: ["Steven Spielberg"]
        directors: ["Makoto Shinkai"]
        writers: ["Hayao Miyazaki"]
        studios: ["Studio Ghibli"]
        release_years: 5
      radarr:
        tags: ["some tag"]
        languages: ["en", "pt"]
        profiles: ["1080p"]
      trakt:
        max_items_per_list: 200
        lists:
          [
            "https://trakt.tv/movies/trending",
            "https://trakt.tv/movies/popular",
            "https://trakt.tv/movies/watched/yearly",
            "https://trakt.tv/movies/collected/yearly",
            "https://trakt.tv/users/justin/lists/imdb-top-rated-movies"
          ]

What do you think? It's way more robust but I'm afraid the overlapping settings could cause some confusion.

Another alternative is to check each field against every field that possible maps on each provider, but that makes what is happening way less obvious.

@rfsbraz rfsbraz self-assigned this Sep 1, 2023
@mlamoure
Copy link
Author

mlamoure commented Sep 2, 2023

Yes I like the approach you outlined in the config. Makes sense to organize the exclusion criteria based on where it comes from. I would rename tags to labels in the plex section. Happy to test If you'd like.

@mlamoure
Copy link
Author

Wondering if you plan to progress this one in the near term? Eagerly awaiting this as I will be able to retire the poorly built system I wrote myself that does this same thing.

@rfsbraz
Copy link
Owner

rfsbraz commented Sep 30, 2023

@mlamoure yes, I have an ongoing branch with these changes I have just been lacking the time to dedicate myself to it, my bad.

@mlamoure
Copy link
Author

mlamoure commented Oct 4, 2023

Awesome! Thanks for the update. Eagerly following progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants