From 5e8ca81633048d8fad49d639227f90c20beaef24 Mon Sep 17 00:00:00 2001
From: retorquere <emilano.heyns@iris-advies.com>
Date: Fri, 29 May 2015 11:18:39 +0200
Subject: [PATCH] verify cache objects in debug mode

---
 Rakefile                                      |  2 +-
 .../content/zotero-better-bibtex/cache.coffee | 36 +++++++++++++++++--
 2 files changed, 34 insertions(+), 4 deletions(-)

diff --git a/Rakefile b/Rakefile
index 94e524568b..4de121982a 100644
--- a/Rakefile
+++ b/Rakefile
@@ -338,7 +338,7 @@ task :test, [:tag] => [XPI, :plugins] do |t, args|
     end
 
     if OS.mac?
-      sh "script -q -t 1 cucumuber.log cucumber --require features #{rerun} --strict #{tag}"
+      sh "script -q -t 1 cucumuber.log cucumber --strict #{tag}"
     else
       sh "script -ec 'cucumber --require features #{rerun} --strict #{tag}' cucumber.log"
     end
diff --git a/chrome/content/zotero-better-bibtex/cache.coffee b/chrome/content/zotero-better-bibtex/cache.coffee
index 4d3c89b12f..8a605f570b 100644
--- a/chrome/content/zotero-better-bibtex/cache.coffee
+++ b/chrome/content/zotero-better-bibtex/cache.coffee
@@ -39,6 +39,37 @@ Zotero.BetterBibTeX.cache = new class
     @cache.flushChanges()
     @access.flushChanges()
 
+  verify: (entry) ->
+    return entry unless Zotero.BetterBibTeX.pref.get('debug') || Zotero.BetterBibTeX.pref.get('testMode')
+
+    verify = {itemID: 1, exportCharset: 'x', exportNotes: true, getCollections: true, preserveBibTeXVariables: true, translatorID: 'x', useJournalAbbreviation: true }
+
+    for own key, value of entry
+      switch
+        when key in ['$loki', 'meta'] then # ignore
+
+        when verify[key] == undefined
+          throw new Error("Unexpected field #{key} in #{typeof entry} #{JSON.stringify(entry)}")
+
+        when verify[key] == null
+          delete verify[key]
+
+        when typeof verify[key] == 'string' && typeof value == 'string' && value.trim() != ''
+          delete verify[key]
+
+        when typeof verify[key] == 'number' && typeof value == 'number'
+          delete verify[key]
+
+        when typeof verify[key] == 'boolean' && typeof value == 'boolean'
+          delete verify[key]
+
+        else
+          throw new Error("field #{key} of #{typeof entry} #{JSON.stringify(entry)} is unexpected #{typeof value} #{value}")
+
+    verify = Object.keys(verify)
+    return entry if verify.length == 0
+    throw new Error("missing fields #{verify} in #{typeof entry} #{JSON.stringify(entry)}")
+
   remove: (what) ->
     what.itemID = @integer(what.itemID) unless what.itemID == undefined
     @cache.removeWhere(what)
@@ -91,8 +122,7 @@ Zotero.BetterBibTeX.cache = new class
     @access.flushChanges()
 
   record: (itemID, context) ->
-    throw new Error("No translator ID supplied in #{JSON.stringify(Object.keys(context))}") unless context.translatorID
-    return {
+    return @verify({
       itemID: @integer(itemID)
       exportCharset: (context.exportCharset || 'UTF-8').toUpperCase()
       exportNotes: !!context.exportNotes
@@ -100,7 +130,7 @@ Zotero.BetterBibTeX.cache = new class
       preserveBibTeXVariables: !!context.preserveBibTeXVariables
       translatorID: context.translatorID
       useJournalAbbreviation: !!context.useJournalAbbreviation
-    }
+    })
 
   clone: (obj) ->
     clone = JSON.parse(JSON.stringify(obj))