Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Approve Transaction Modal - Sending Unlimited XYZ #2959

Open
0xonerb opened this issue Sep 27, 2024 · 6 comments
Open

[bug] Approve Transaction Modal - Sending Unlimited XYZ #2959

0xonerb opened this issue Sep 27, 2024 · 6 comments
Labels
bug Something isn't working

Comments

@0xonerb
Copy link

0xonerb commented Sep 27, 2024

Link to minimal reproducible example

N/A

Summary

Why does the Sending field say "Unlimited" instead of the amount the user is sending?

Screenshot from 2024-09-27 14-59-52

List of related npm package versions

"dependencies": {
  "@reown/appkit": "^1.0.4",
  "@reown/appkit-adapter-wagmi": "^1.0.4",
  "@tanstack/react-query": "^5.40.1",
  "@wagmi/core": "^2.13.4",
  "next": "^14.2.9",
  "react": "^18.3.1",
  "react-dom": "^18.3.1",
  "viem": "^2.21.2",
  "wagmi": "^2.12.8",
},
@0xonerb 0xonerb added bug Something isn't working needs review labels Sep 27, 2024
@rtomas
Copy link
Contributor

rtomas commented Sep 29, 2024

hi @0xonerb
can you show me what are you approving ?

@0x33dm
Copy link

0x33dm commented Sep 30, 2024

hi @0xonerb

can you show me what are you approving ?

In this case it's a regular ERC-20 Approve call.

On metamask it shows the amount correctly, but when testing wallet with authentication we are seeing "unlimited".

@0xonerb
Copy link
Author

0xonerb commented Sep 30, 2024

hi @0xonerb
can you show me what are you approving ?

Hey @rtomas... as @0x33dm said, it's a regular ERC-20 Approve call.

@0xonerb
Copy link
Author

0xonerb commented Oct 2, 2024

Hey @rtomas, here are two transactions:

Screenshot from 2024-10-02 18-18-31

As you can see, in our app we made a transaction with an amount of 5:

Screenshot from 2024-10-02 18-22-06

The AppKit modal shows Unlimited WETH??

Screenshot from 2024-10-02 18-24-16

Screenshot from 2024-10-02 11-00-19
Screenshot from 2024-10-02 11-00-11

@rtomas
Copy link
Contributor

rtomas commented Oct 3, 2024

https://linear.app/reown/issue/APKT-1239/[bug]-showing-sending-unlimited-usdt-when-approving-erc-20

@arein
Copy link
Contributor

arein commented Dec 12, 2024

@0x33dm @0xonerb sorry for the delay - it may have been fixed - checking with the team

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants