onNodeDoubleClick firing multiple times

[faseidl]

I just tried using onNodeDoubleClick for the first time. I created a handler function that simply logs the node to the browser console. I'm seeing that double-clicking a node calls the event handler multiple times (two or three times). Is this a known behavior? If not, any ideas on what I might be doing to provoke this? Thx!

[faseidl]

My solution:

    // We wrap the onNodeClick and onNodeDoubleClick handlers (if any) to add logic to debounce double
    // clicks. The problem is that if both handlers are applied to the same node, we want a double-
    // click event to disable the single-click event. The trouble is, the first click of a double click
    // triggers onNodeClick before the double-click event is recognized. We use a timer and and flag to
    // suppress the single click if a double click occurs.
    // See: https://stackoverflow.com/questions/48295288/how-to-handle-single-click-and-double-click-on-the-same-html-dom-element-usi
    let isDoubleClick = React.useRef(false);
    let singleClickTimeout = 200; // Timeout before recognizing a single click

    let onNodeClick =
      onNodeClick->mapSome(handler => {
        let wrapper = node => {
          let f = () =>
            if (!isDoubleClick.current) {
              handler(node);
            };
          isDoubleClick.current = false;
          Js.Global.setTimeout(~f, singleClickTimeout)->ignore;
        };
        Some(wrapper);
      });

    let onNodeDoubleClick =
      onNodeDoubleClick->mapSome(handler => {
        let wrapper = (node, event) => {
          isDoubleClick.current = true;
          handler(node, event);
        };
        Some(wrapper);
      });

Idea: Maybe this sort of logic could be added to reagraph.

[amcdnl]

Happy to accept a PR or documentation on best practice!