Skip to content
This repository has been archived by the owner on Jul 19, 2019. It is now read-only.

modern browser colors cause an error #83

Open
boygirl opened this issue Jan 23, 2016 · 3 comments
Open

modern browser colors cause an error #83

boygirl opened this issue Jan 23, 2016 · 3 comments

Comments

@boygirl
Copy link

boygirl commented Jan 23, 2016

Hi there!

I'm converting a react library from svg to react-art, and I got hung up on using colors like "tomato", which cause an error, and result in nothing being rendered. I tracked the problem down to the art library, and opened a PR there. sebmarkbage/art#12. I'd love a version bump whenever that lands.

Thanks!

@boygirl
Copy link
Author

boygirl commented Jan 24, 2016

P.S. you can test out this change in art on my branch https://github.com/formidablelabs/react-art/tree/supportBrowserColors

@sebmarkbage
Copy link
Contributor

See my comment in sebmarkbage/art#12

We'd have to make a solid case for why everyone else using this library with custom colors should have to download this list of hardcoded colors. Generally I think it makes more sense to define your own list of hardcoded colors.

E.g. myColorSet.highlightedRed or myColorSet.buttonColor. You can have your own list just represent the built-in browser colors if you want.

@boygirl
Copy link
Author

boygirl commented Apr 26, 2016

@sebmarkbage see comment on sebmarkbage/art#12

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants