Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: dev conda enviornment not working with sphinx 8.1.0 #463

Closed
ncclementi opened this issue Oct 10, 2024 · 3 comments · Fixed by #470
Closed

bug: dev conda enviornment not working with sphinx 8.1.0 #463

ncclementi opened this issue Oct 10, 2024 · 3 comments · Fixed by #470

Comments

@ncclementi
Copy link
Contributor

I was trying to install the dev dependencies following the instruction from the readme, and with the latest release (v8.1.0 released recently) I get an error when trying to do make dirhtml

Running Sphinx v8.1.0
loading translations [en]... done

Extension error:
Could not import extension sphinxcontrib.mermaid (exception: cannot import name 'ExtensionError' from 'sphinx.util' (.../miniforge3/envs/deployment-docs-dev/lib/python3.12/site-packages/sphinx/util/__init__.py))
make: *** [dirhtml] Error 2

If I downgrade to sphinx=8.0.2 the problem is resolved. Not sure exactly what the problem is but a potential temporary solution would be to pin sphinx. Happy to open a PR, if you think this is the right way to do go about it.

@jacobtomlinson
Copy link
Member

Thanks for raising this @ncclementi! Yeah it looks like 8.1.0 released yesterday and broke the build here. Pinning would be good but I expect a fix either needs to go into sphinx or sphinxcontrib-mermaid to fix this properly.

@jacobtomlinson
Copy link
Member

I've opened #469 to add an upper bound to Sphinx and also mgaitan/sphinxcontrib-mermaid#161 to fix this upstream.

@jameslamb
Copy link
Member

Thanks for handling this @jacobtomlinson !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants