Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Add testing for reading parquet files with lists spanning multiple pages. #17706

Closed
pmattione-nvidia opened this issue Jan 9, 2025 · 1 comment · Fixed by #17735
Closed

[FEA] Add testing for reading parquet files with lists spanning multiple pages. #17706

pmattione-nvidia opened this issue Jan 9, 2025 · 1 comment · Fixed by #17735
Assignees
@pmattione-nvidia
Labels
feature request New feature or request

Comments

@pmattione-nvidia
Copy link
Contributor

There was a bug in the parquet reader that was recently exposed and fixed here, where a list was so long that it spanned multiple pages. cudf currently doesn't have any tests for this case, as the cudf parquet writer can't even generate files that have this. We need to manually add in some files that expose these edge cases so that we can create and run tests on them.
@pmattione-nvidia pmattione-nvidia added the feature request New feature or request label Jan 9, 2025
@pmattione-nvidia pmattione-nvidia self-assigned this Jan 9, 2025
@pmattione-nvidia pmattione-nvidia mentioned this issue Jan 14, 2025
Merged
3 tasks
@pmattione-nvidia
Copy link
Contributor Author

This work is done here: #17735

rapids-bot bot pushed a commit that referenced this issue Jan 16, 2025
@pmattione-nvidia
Add parquet reader long row test (#17735)
3cad1a6 
Adds a python test that makes sure that the parquet reader can correctly handle a list row that spans more than one page. This test resolves [this issue](#17706), which was created to catch problems that can happen like the bug [fixed here](#17699). This test passes now, but fails if the given fix is not present.

Authors:
  - Paul Mattione (https://github.com/pmattione-nvidia)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: #17735
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pmattione-nvidia pmattione-nvidia

Labels
feature request New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add parquet reader long row test pmattione-nvidia/cudf
1 participant
@pmattione-nvidia