[SURE-9649] Kustomize nameSuffix not working with Fleet

[kkaempf]

SURE-9649

Issue description:

NameSuffix directive in Kustomize doesn't work with Fleet but it's working fine only with kustomize CLI

Business impact:

Not possible to deploy 100 CRs using the nameSuffix to avoid naming collision

Repro steps:

(see JIRA for full yaml files)

Create a repo with the following secret in the base template file:

apiVersion: v1
kind: Secret
metadata:
  name: downstream-node
  namespace: default
type: Opaque
data:
  username: xxx
  password: xxx

The kustomize.yaml in the overlay:

nameSuffix: "-0"
resources:
  - ../../base  # Point to the base folder
patchesStrategicMerge:
  - secret-patch.yaml 

where the name suffix will add the -0 to -99 (in the example we want to deploy 100 CRs without collision)

The secret-patch.yaml will modify the values (kustomize and fleet are doing well this part) and it will try to rename the resource name to add the suffix:

apiVersion: v1
kind: Secret
metadata:
  name: downstream-node
  namespace: default
type: Opaque
data:
  username: xxx
  password: xxx

Actual behavior:

Using fleet the replacement file is:

apiVersion: v1
kind: Secret
metadata:
  name: downstream-node
  namespace: default
type: Opaque
data:
  username: xxx
  password: xxx

Expected behavior:

But the expected output (the same output you can get doing a manual kustomize build . command) is:

apiVersion: v1
kind: Secret
metadata:
  name: downstream-node-0
  namespace: default
type: Opaque
data:
  username: xxx
  password: xxx

where the values are replaced as well as the metadata.name with the suffix included