Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ivy-resume is broken with ivy-prescient #102

Open
p1llule opened this issue Mar 10, 2021 · 2 comments
Open

ivy-resume is broken with ivy-prescient #102

p1llule opened this issue Mar 10, 2021 · 2 comments
Labels

Comments

@p1llule
Copy link

p1llule commented Mar 10, 2021

Hi.

ivy-resume can be used with a argument to restore a previous ivy session.

This doesn't work with ivy-prescient installed.

Steps to reproduce :

  1. have ivy and ivy-prescient enabled.
  2. register an ivy session (eg: call M-x or wathever)
  3. C-u ivy-resume
  4. ivy-prescient-sort-function: Wrong type argument: sequencep, counsel-M-x

My workaround for the time being is :
(add-to-list 'ivy-sort-functions-alist (list 'ivy-resume))

oh and I have this config from doom @hlissner which already exclude ivy-resume but that's not relevant here.
(setq ivy-prescient-sort-commands
'(:not swiper swiper-isearch ivy-switch-buffer
ivy-resume ivy--restore-session lsp-ivy-workspace-symbol
counsel-grep counsel-git-grep counsel-rg counsel-ag
counsel-ack counsel-fzf counsel-pt counsel-imenu
counsel-yank-pop counsel-recentf counsel-buffer-or-recentf)
ivy-prescient-retain-classic-highlighting t)

@p1llule
Copy link
Author

p1llule commented Mar 10, 2021

I suppose there is something more elegant to do but waiting advice,

@clemera
Copy link
Collaborator

clemera commented Mar 11, 2021

Thanks, also see #65

@raxod502 raxod502 added the ivy label Mar 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

3 participants