From 79fd87aad8ae33c6bb84970ae2b7ef0aa3bd6404 Mon Sep 17 00:00:00 2001
From: Ahmed El-Helw <ahmedre@gmail.com>
Date: Sat, 18 Nov 2023 01:24:13 +0400
Subject: [PATCH] Use Kitab font for inline Arabic translation

This uses the Kitab font for the inline ayah translation view, just like
the full screen translation view does. This helps fix artifacts and
strange issues on older phones with how some characters are rendered.
Also made the Arabic text slightly larger in this view. Fixes #2459.
---
 .../ui/helpers/TypefaceWrappingSpan.kt        | 16 ++++++++++++
 .../view/InlineTranslationView.kt             | 25 ++++++++++++++++++-
 2 files changed, 40 insertions(+), 1 deletion(-)
 create mode 100644 app/src/main/java/com/quran/labs/androidquran/ui/helpers/TypefaceWrappingSpan.kt

diff --git a/app/src/main/java/com/quran/labs/androidquran/ui/helpers/TypefaceWrappingSpan.kt b/app/src/main/java/com/quran/labs/androidquran/ui/helpers/TypefaceWrappingSpan.kt
new file mode 100644
index 0000000000..e14ab0501e
--- /dev/null
+++ b/app/src/main/java/com/quran/labs/androidquran/ui/helpers/TypefaceWrappingSpan.kt
@@ -0,0 +1,16 @@
+package com.quran.labs.androidquran.ui.helpers
+
+import android.graphics.Typeface
+import android.text.TextPaint
+import android.text.style.MetricAffectingSpan
+
+class TypefaceWrappingSpan(private val typeface: Typeface) : MetricAffectingSpan() {
+
+  override fun updateDrawState(ds: TextPaint) {
+    ds.typeface = typeface
+  }
+
+  override fun updateMeasureState(paint: TextPaint) {
+    paint.typeface = typeface
+  }
+}
diff --git a/app/src/main/java/com/quran/labs/androidquran/view/InlineTranslationView.kt b/app/src/main/java/com/quran/labs/androidquran/view/InlineTranslationView.kt
index ea30f212ff..2c4b225e72 100644
--- a/app/src/main/java/com/quran/labs/androidquran/view/InlineTranslationView.kt
+++ b/app/src/main/java/com/quran/labs/androidquran/view/InlineTranslationView.kt
@@ -8,7 +8,9 @@ import android.text.SpannableStringBuilder
 import android.text.Spanned
 import android.text.TextUtils
 import android.text.style.ForegroundColorSpan
+import android.text.style.RelativeSizeSpan
 import android.text.style.StyleSpan
+import android.text.style.TypefaceSpan
 import android.util.AttributeSet
 import android.view.View
 import android.widget.LinearLayout
@@ -16,10 +18,14 @@ import android.widget.ScrollView
 import android.widget.TextView
 import androidx.annotation.StyleRes
 import androidx.core.content.ContextCompat
+import com.quran.common.search.SearchTextUtil
 import com.quran.labs.androidquran.R
 import com.quran.labs.androidquran.common.LocalTranslation
 import com.quran.labs.androidquran.common.QuranAyahInfo
 import com.quran.labs.androidquran.common.TranslationMetadata
+import com.quran.labs.androidquran.ui.helpers.TypefaceWrappingSpan
+import com.quran.labs.androidquran.ui.translation.TranslationAdapter
+import com.quran.labs.androidquran.ui.util.TypefaceManager
 import com.quran.labs.androidquran.util.QuranSettings
 
 class InlineTranslationView @JvmOverloads constructor(
@@ -135,7 +141,7 @@ class InlineTranslationView @JvmOverloads constructor(
         }
 
         // irrespective of whether it's a link or not, show the text
-        builder.append(stylize(ayah.texts[i], translationText))
+        builder.append(stylize(ayah.texts[i], translations[i].languageCode, translationText))
       }
     }
     ayahView.append(builder)
@@ -159,10 +165,27 @@ class InlineTranslationView @JvmOverloads constructor(
 
   private fun stylize(
     metadata: TranslationMetadata,
+    languageCode: String? = null,
     translationText: String
   ): CharSequence {
     val spannableStringBuilder = SpannableStringBuilder(translationText)
 
+    if (languageCode == "ar") {
+      val spans = listOf(
+        TypefaceWrappingSpan(TypefaceManager.getTafseerTypeface(context)),
+        RelativeSizeSpan(1.1f)
+      )
+
+      spans.forEach { span ->
+        spannableStringBuilder.setSpan(
+          span,
+          0,
+          spannableStringBuilder.length,
+          Spanned.SPAN_EXCLUSIVE_EXCLUSIVE
+        )
+      }
+    }
+
     metadata.ayat.forEach { range ->
       val span = ForegroundColorSpan(inlineAyahColor)
       spannableStringBuilder.setSpan(