Skip to content
This repository has been archived by the owner on Jun 19, 2021. It is now read-only.

Consider using react.js #41

Open
skullydazed opened this issue Jan 20, 2017 · 3 comments
Open

Consider using react.js #41

skullydazed opened this issue Jan 20, 2017 · 3 comments

Comments

@skullydazed
Copy link
Member

http://reactdesktop.js.org

React is a cross-platform library with widgets that look native. We should consider using this for a more native feel on each platform.

You can view a demo in chrome: http://reactdesktop.js.org/demo/

@NoahAndrews
Copy link
Contributor

I was expecting an older style of Windows theme. I really like that this uses the modern Windows design language.

Unfortunately, I think this would greatly increase the amount of code specific to the Windows and Mac platforms. For instance, it's literally got two separate Button components with different properties for the two platforms.

Still, it really looks fantastic aesthetically. I'd love to see if we can use this with a decent amount of UI code reuse between platforms.

@jakebesworth
Copy link

React is not free/libre open source software, so it's probably best not to include it in QMK.

@jackhumbert
Copy link
Member

jackhumbert commented Sep 4, 2017

I think we're going in a different direction with this - specific OS sources seems to be the best way forward on this. To avoid confusion, we're starting this in qmk/qmk_toobox, which includes some other features besides flashing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants