Skip to content
This repository has been archived by the owner on Apr 3, 2024. It is now read-only.

Catch navigation before it happens #2

Open
wvengen opened this issue Jul 19, 2018 · 4 comments
Open

Catch navigation before it happens #2

wvengen opened this issue Jul 19, 2018 · 4 comments

Comments

@wvengen
Copy link
Member

wvengen commented Jul 19, 2018

Several workarounds were needed to cancel navigating to a link that is supposed to load in the system web browser. Something like the CB-14188 PR would allow inspecting the URL and cancel loading the external page before it happens. This would allow removing quite some code, be less error-prone, and provide a better experience.

Finish the PR and integrate it. Work has already started on branch feature/beforeload.

@wvengen
Copy link
Member Author

wvengen commented Jun 13, 2019

Done in 08cdf40. When a new version of InAppBrowser is released (3.0.0+), use that plugin from npm.

@wvengen wvengen closed this as completed Jun 13, 2019
@wvengen
Copy link
Member Author

wvengen commented Jul 9, 2019

Verified on iOS.
Discovered an issue on Android where the first time an external link is clicked, the beforeload event does not seem to be caught. Subsequent times work fine.

@wvengen wvengen reopened this Jul 9, 2019
@koekaverna
Copy link

Hello, I like this project and it very helpfull.
I have a problem with the beforeload event, which did not work when visiting an odd link only on even.
I also created an issue here apache/cordova-plugin-inappbrowser#686

@wvengen
Copy link
Member Author

wvengen commented May 4, 2020

Thanks for your message, I hope to be able to look into this again at some point.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants