Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROCm support missing from Dockerfile #3380

Open
jakki-amd opened this issue Jan 7, 2025 · 0 comments · May be fixed by #3381
Open

ROCm support missing from Dockerfile #3380

jakki-amd opened this issue Jan 7, 2025 · 0 comments · May be fixed by #3381

Comments

@jakki-amd
Copy link
Contributor

🚀 The feature

Currently the solution to use TorchServe with ROCm and Docker relies on separate Dockerfile Dockerfile.rocm and ROCm support is missing from Dockerfile. build_image.sh operates with Dockerfile and provides many useful build flags. Adding ROCm support for Dockerfile would make ROCm to adhere the repository standards and leverage the utility tooling created for Docker image building.

Motivation, pitch

Dockerfile.rocm relies on installing ROCm dependencies separately on top of the base image and produces large Docker images. It also doesn't have build_image.sh support. I would like to create Docker images that have ROCm support using build_image.sh script.

Alternatives

No response

Additional context

No response

@jakki-amd jakki-amd linked a pull request Jan 8, 2025 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant