Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configuration option for default loop scope #793

Open
seifertm opened this issue Feb 28, 2024 · 3 comments · May be fixed by #1035
Open

Configuration option for default loop scope #793

seifertm opened this issue Feb 28, 2024 · 3 comments · May be fixed by #1035
Labels
enhancement
Milestone
v1.0

Comments

@seifertm
Copy link
Contributor

seifertm commented Feb 28, 2024 •
edited
Loading

When a user wants to run all tests in a session-scoped event loop, the documentation suggests implementing a pytest_collection_modifyitems hook.

In auto mode the hook causes duplicate asyncio markers to be attached to test items. This is a cosmetic issue, but creates additional noise when debugging item markers.

In strict mode the behavior of the hook rules out manual overrides of the asyncio mark.

A configuration option for the default loop scope as suggested in #705 (comment) would eliminate duplicate asyncio markers in auto mode and allow overriding the default loop scope with explicit markers in strict mode.
@seifertm seifertm added this to the v1.0 milestone Feb 28, 2024
@seifertm seifertm mentioned this issue Jul 31, 2024
Closed
@minrk
Copy link

minrk commented Aug 7, 2024

0.24 adds essentially this option for fixtures in asyncio_default_fixture_loop_scope. It seems logical to me to add an equivalent for tests as well at the same time. The modifyitems approach definitely works, but is more complex, and having this option only for fixtures makes it all the more tantalizing to not have it for the tests themselves.

@BryceCicada BryceCicada mentioned this issue Sep 5, 2024
Closed
@seifertm seifertm mentioned this issue Sep 19, 2024
Open
@seifertm seifertm pinned this issue Sep 19, 2024
@seifertm seifertm mentioned this issue Sep 25, 2024
Closed
@seifertm seifertm mentioned this issue Dec 6, 2024
Closed
@Novakov
Copy link

Novakov commented Jan 5, 2025

Do you know if someone is working on this configuration option? If not, I think I can spend some time on it and make a PR.

By looking at the code, it seems to me that default value from configuration option shall be applied in (or around calls to) _get_marked_loop_scope.

@seifertm
Copy link
Contributor Author

seifertm commented Jan 5, 2025

I'm not ware that anyone is currently working on this. If you can contribute a PR, that's great!

Your idea sounds good. You somehow need to access Config, in order to get the configured value. This should be possible from both call sites, where Item and Metafunc are available, respectively.

Pytest-asyncio isn't particularly easy to hack on, so let me know if you get stuck!

@Novakov Novakov linked a pull request Jan 6, 2025 that will close this issue
Open
@seifertm seifertm linked a pull request Jan 8, 2025 that will close this issue
feat: Configuration option for setting default loop_scope for tests #1035
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v1.0
Development

Successfully merging a pull request may close this issue.

feat: Configuration option for setting default loop_scope for tests Novakov/pytest-asyncio
3 participants
@minrk @Novakov @seifertm