Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] natural imports for vendors break package within site-packages.zip #4640

Closed
gaborbernat opened this issue Sep 7, 2024 · 2 comments
Closed

Comments

@gaborbernat
Copy link
Contributor

gaborbernat commented Sep 7, 2024

setuptools version

setuptools 74.1

Python version

Any

OS

Any

Additional environment information

No response

Description

#4457 breaks the tool being zipped up in a site-packages.zip... The use case was originally submitted to virtualenv via pypa/virtualenv#1715

Expected behavior

It works.

How to Reproduce

pypa/virtualenv#1715

Output

Discovered during pypa/virtualenv#2760, see https://github.com/pypa/virtualenv/actions/runs/10752988428/job/29821925275?pr=2760

@gaborbernat gaborbernat added bug Needs Triage Issues that need to be evaluated for severity and status. labels Sep 7, 2024
@FinnWoelm
Copy link

Hey @gaborbernat, thanks so much for filing this issue. Helped us debug why our Zappa deployment stopped working.

We are working around it for now by manually installing the last compatible version of virtualenvs and setuptools.

# GitHub action

jobs:
  build_and_deploy:
    steps:
    # ... more steps here ...

    # Note (Sep 9, 2024): setuptools 74.1.2 breaks imports within site-packages.zip, which causes the zappa deployment
    # to fail. Virtualenv 20.26.3 still uses a compatible version of setuptools. Once this issue gets fixed, we can
    # remove this step.
    # See issue: https://github.com/pypa/setuptools/issues/4640
    # See setuptools PR: https://github.com/pypa/setuptools/pull/4457
    # See virtualenv PR: https://github.com/pypa/virtualenv/pull/2760
    - name: Set fixed setuptools version
      run: pip3 install virtualenv==20.26.3 setuptools==70.1.0

    # ... more steps here ...

@jaraco
Copy link
Member

jaraco commented Sep 9, 2024

Investigation happening in #4641.

@jaraco jaraco closed this as completed Sep 9, 2024
@jaraco jaraco added duplicate and removed Needs Triage Issues that need to be evaluated for severity and status. labels Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants