value_receiver vs _value_receiver?

[XzzX]

class DataChannel(FlavorChannel["DataChannel"], typing.Generic[ReceiverType], ABC):
    def __init__(
        self,
        label: str,
        owner: HasIO,
        default: typing.Any | None = NOT_DATA,
        type_hint: typing.Any | None = None,
        strict_hints: bool = True,
        value_receiver: ReceiverType | None = None,
    ):
        ...
        self.value_receiver: ReceiverType = value_receiver

    @property
    def value_receiver(self) -> Self | None:
        return self._value_receiver

Is this a bug, or is this intended? value_receiver vs _value_receiver?

[liamhuber]

This is completely intended. value_receiver is a setter/getter property. The underlying _value_receiver is earlier set to some default value, and this pattern is leveraged to have the setter sanitize whatever value_receiver arg the user has passed into __init__

    def __init__(
        ...
        value_receiver: ReceiverType | None = None,
    ):
        ...
        self._value_receiver = None
        ....
        self.value_receiver: ReceiverType = value_receiver

    ...

    @value_receiver.setter
    def value_receiver(self, new_partner: Self | None):
        if new_partner is not None:
            ...

[XzzX]

self.value_receiver: ReceiverType = value_receiver

The type hint is misleading as it suggests a declaration shadowing your property.
You could also get rid of ReceiverType entirely as you only allow Self.

[liamhuber]

You're right that the attribute doesn't need a hint since the property has one, but the property hint should actually be ReceiverType not Self. We can't get rid of ReceiverType because there is a subclass of the output data channel: #569

[XzzX]

You're right that the attribute doesn't need a hint since the property has one, but the property hint should actually be ReceiverType not Self. We can't get rid of ReceiverType because there is a subclass of the output data channel: #569

Fallen into my own trap... I am still confused by the meaning of Channel. But yes, of course, you are right.