Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why bypass the getter for GenericJob.executor_type? #1387

Open
liamhuber opened this issue Mar 18, 2024 · 0 comments
Open

Why bypass the getter for GenericJob.executor_type? #1387

liamhuber opened this issue Mar 18, 2024 · 0 comments
Assignees
@jan-janssen

Comments

@liamhuber
Copy link
Member

The codebase uses GenericJob._executor_type instead of the property getter GenericJob.executor_type throughout:

I worry this introduces the danger that if we ever introduce logic to the getter, it will be missed and we'll get weird bugs throughout. Is there a compelling case against simply using the public method instead?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jan-janssen jan-janssen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jan-janssen @liamhuber