-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build failing PwmHttpClientTest #647
Comments
Hmm, not getting this issue with a clean install of Cent0S 7 and latest Java 11 installed from the distro. I don't have RHEL to test on. Is there anything else unusual about your server/jvm setup? [vm@localhost pwm]$ git log -1
[vm@localhost pwm]$ git branch
[vm@localhost pwm]$ cat /etc/os-release CENTOS_MANTISBT_PROJECT="CentOS-7" [vm@localhost pwm]$ ./mvnw verify ...snip.... INFO] ------------------------------------------------------------------------ |
Thank you for the response. Here is some additional information from the build above. I will try my build on CentOS Stream 8 later today and see if it runs into the same problem. I'll also see if I can find any other helpful information. [user@pwm01-test pwm]# git log -1
[user@pwm01-test pwm]# git branch
[user@pwm01-test ~]$ java -version -- test server [user@pwm01 ~]$ java -version -- production server To help verify, I ran, [user@pwm01-test pwm]# git log -1
[user@pwm01-test pwm]# ./mvnw clean verify ...snip... [INFO] ------------------------------------------------------------------------ After I ran, [user@pwm01-test pwm]# git log -1
[user@pwm01-test pwm]# ./mvnw clean verify ...snip... [INFO] Results: |
Hi Jason, I was able to replicate the issue with CentOS 8 Stream. I setup a new virutal machine with the following settings - CentOS 8 Stream - Minimal Install dnf install git java-11-openjdk java-11-openjdk-devel bzip2 unzip wget [root@pwm02-test pwm]# git log -1
[root@pwm02-test pwm]# git branch
[root@pwm02-test pwm]# java -version [root@pwm02-test pwm]# cat /etc/os-release [root@pwm02-test pwm]# ./mvnw clean verify ...snip... [ERROR] Errors: [root@pwm02-test pwm]# git checkout 437e617 [root@pwm02-test pwm]# git log -1
[root@pwm02-test pwm]# ./mvnw clean verify ...snip... [INFO] ------------------------------------------------------------------------ |
It looks like inside server/src/test/java/password/pwm/http/client/PwmHttpClientTest.java a test certificate is created.
I think if we update server/src/main/java/password/pwm/util/secure/self/SelfCertSettings.java to 2048 then it might resolve the issue.
I can try it on my system and try to do a Pull Request. |
Updating that keySize did fix the build on CentOS Stream 8. I will test it on RHEL8 and see if I can figure out how to do a Pull Request for it. [root@pwm02-test pwm]# git log -1
[root@pwm02-test pwm]# cat server/src/main/java/password/pwm/util/secure/self/SelfCertSettings.java | grep 2048
[root@pwm02-test pwm]# ./mvnw clean verify ...snip... [INFO] ------------------------------------------------------------------------ |
So I've been looking into this for past few days and I'm a bit confused why CentOS Stream 8/9 is having trouble with the 2048 key size. I've tested half dozen other distros default JDK without issue, as well as Win11+Terminum JDK. It took me awhile to figure out CentOS "Stream" replaced CentOS, but after I did I tested 8/9 and saw the same errors as you. However if I grab Azul or Temurin build of 11.0.14 and use on CentOS Stream 8/9 it works fine, so this appears to be an issue purely with the CentOS Stream builds of OpenJDK. I looked at the java.security properties file of the CentOS Stream JDKs, but I couldn't see any reason why it would limit the keysize to 1024. I changed the keysize from 1024 in PWM, because best practices are now >= 2048 for RSA keys, and had an issue with WireMock at 1024 - though WireMock is quite fragile and my issue may have been unrelated. I'm reluctant to downgrade the default self service key back to 1024, but if we can figure out a way to parameterize it for the test that might be a workable solution..... |
Describe the bug
We are trying to build from the latest source and PwmHttpClientTest is failing.
We are running RHEL8 and have tried Open JDK 11 and 17. The build worked on this server around a month ago.
It may be related to this commit? - d9cadfb
To Reproduce
Steps to reproduce the behavior:
Additional context
The text was updated successfully, but these errors were encountered: