Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to put some documentation on why we need patched version of vagrant-hostmanager plugin #135

Open
LalatenduMohanty opened this issue Oct 5, 2015 · 3 comments

Comments

@LalatenduMohanty
Copy link

Need to put some documentation on why we need patched [3] version of vagrant-hostmanager plugin [1].
I think we can add some more doc to [2]

[1] https://github.com/purpleidea/vagrant-hostmanager
[2] https://github.com/purpleidea/oh-my-vagrant/blob/master/DOCUMENTATION.md#i-am-seeing-a-similar-error-that-mentions-hostmanager-the-error-looks-like
[3] https://github.com/purpleidea/oh-my-vagrant/blob/master/extras/patch-hostmanager.sh#L28

@purpleidea
Copy link
Owner

@LalatenduMohanty ACK.

The reason is because the upstream plugin hasn't merged my patch from april. devopsgroup-io/vagrant-hostmanager#145 so I worked around it as shown. At some point, it would be great if someone pushes to try and get it in, but unresponsive maintainer + hack that works well is fine for me. Additionally I think @strzibny is working on making landrush plugin work which may be an acceptable (although not as good) alternative.

@msabramo
Copy link

👍 I was just reading the docs and I was quite curious about this.

@purpleidea
Copy link
Owner

@msabramo is it clear now? want to help get that patch upstream? cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants