Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Site Information Configuration for Aeon #1487

Closed
6 of 9 tasks
kevinreiss opened this issue Jan 13, 2025 · 0 comments · Fixed by #1489
Closed
6 of 9 tasks

Update Site Information Configuration for Aeon #1487

kevinreiss opened this issue Jan 13, 2025 · 0 comments · Fixed by #1489
Assignees
Labels
dls-work-cycle Tickets designated for the next work cycle (limit 16) sudden-priority

Comments

@kevinreiss
Copy link
Member

kevinreiss commented Jan 13, 2025

What maintenance needs to be done?

The "RBSC" site value in Aeon has been changed to the string "FIRE". The label and URL values attached to this site do NOT need to change only this string.

Level of urgency

  • High
  • Moderate
  • Low

Acceptance Criteria

  • When submitting data to AEON it sends "FIRE" instead of "RBSC" in the SITE field.

First Step

  • Replace all instances of RBSC with FIRE in the codebase.

Why is this maintenance needed?

  • The string has already been changed in Aeon's configuration. Requests are still being submitted successfully but this string needs to change in order to keep reporting accurate and consistent in Aeon as the site value is an important grouping filter when using Aeon.

Acceptance criteria

  • If this change touches any of the files referenced in .rubocop_todo.yml create a new ticket to address the rubocop todo.
  • The key used for the site param value is changed from "RBSC" to "FIRE"
  • Update code and associated tests where this value is hardcoded.
  • Confirm requests are successfully submitted to Aeon after the change.

Implementation notes, if any

See ticket Lexy create in orangelight and ticket @regineheberlein created in aspace helpers.

@kevinreiss kevinreiss added the dls-work-cycle Tickets designated for the next work cycle (limit 16) label Jan 13, 2025
@kevinreiss kevinreiss changed the title Update Site Information Confirmation for Aeon Requesting. Update Site Information Configuration for Aeon Jan 13, 2025
@Seanwarren77 Seanwarren77 self-assigned this Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dls-work-cycle Tickets designated for the next work cycle (limit 16) sudden-priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants