Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UNSAFE_LEGACY_RENEGOTIATION_DISABLED error in newer versions of Python #175

Closed
Dilski opened this issue Mar 6, 2023 · 1 comment
Closed

Comments

@Dilski
Copy link

Dilski commented Mar 6, 2023

Some roombas (such as my 600 series) do not support "RFC 5746 secure renegotiation".
Newer versions of Python use OpenSSL 3, which enforces this standard by default - which means that this library does not work on newer versions of python.

There's some discussion on this on the home assistant core github:
home-assistant/core#82775

From my understanding of the issue, I think where this library sets up the mqtt client
https://github.com/pschmitt/roombapy/blob/master/roombapy/remote_client.py#L84
the ssl context would need modifying as described here:

python/cpython#27776 (comment)

I'm happy to implement this fix, just give me the thumbs up if you'd be happy with the change

@Dilski
Copy link
Author

Dilski commented Mar 6, 2023

image
I've got a fix working, and putting together a PR.

Python 3.8+ support for amqtt (a test dependency) is in beta. I'll wait for a stable release of that.

See: Yakifo/amqtt#129

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant