Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON is not being parsed correctly at times #118

Closed
coolantleak opened this issue Feb 20, 2020 · 2 comments
Closed

JSON is not being parsed correctly at times #118

coolantleak opened this issue Feb 20, 2020 · 2 comments

Comments

@coolantleak
Copy link

Hey! We've been using this awesome library in our Unity project for a few months and we're very happy with it.

After we had some issues with some responses coming empty, took a look and found out this project is using Unity's JSON parsing library JsonUtility, which is not very robust. We replaced that in our projects with Json.NET library which is able, among other things, to parse properties on model classes which is kinda standard. Do you mind if I send a pull request replacing JsonUtility? Is there a specific reason why you had to use JsonUtility I'm ignoring? Thanks

@jdnichollsc
Copy link
Member

In this wrapper we're using only utilities from Unity SDK, that's the reason :)
It would be better if we can add a handler here in order to inject any library to parse the response of the server, e.g: #90

@coolantleak
Copy link
Author

coolantleak commented Feb 20, 2020

Yep, that would be a good approach. Using Unity's as default handler has the benefit of not having dependencies and supporting all listed platforms (now and in the future as long as Unity does not mess that up) which seems ok to me. That being said, not supporting plugins or handlers for JSON serialization severely limits the usefulness of the library in this context, so it's a good idea in that sense. I will take a look at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants