Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] WithNetworkConfig not available when using ThreadSafeNucleiEngine #5952

Open
meme-lord opened this issue Jan 3, 2025 · 2 comments · May be fixed by #5972
Open

[FEATURE] WithNetworkConfig not available when using ThreadSafeNucleiEngine #5952

meme-lord opened this issue Jan 3, 2025 · 2 comments · May be fixed by #5972
Labels
Type: Enhancement Most issues will probably ask for additions or changes.

Comments

@meme-lord
Copy link
Contributor

Describe your feature request

I am using nuclei as an SDK
I want to use ThreadSafeNucleiEngine with a lower MaxHostError and Timeout value than the default config but when I use the WithNetworkConfig() option I get an error "Option WithNetworkConfig not supported in thread safe mode". These two options I want to change would be applied when the ThreadSafeNucleiEngine is initialized and I don't think changing them would cause issues with threadsafety.

Describe the use case of the feature

Lowering MaxHostError and Timeout allows me to tweak nuclei's performance to my needs.

Describe alternatives you've considered

No response

Additional context

No response

@meme-lord meme-lord added the Type: Enhancement Most issues will probably ask for additions or changes. label Jan 3, 2025
@GeorginaReeder
Copy link

Thanks for your feature request @meme-lord , we'll take a look into this!

@meme-lord
Copy link
Contributor Author

I would also like to be able to use my own interactsh server using the threadsafe engine but it has the same problem as the networkconfig.
In the case of the interactsh config it seems the config would get used when NucleiEngine.init() is called in NewThreadSafeNucleiEngineCtx when the interactshClient get initialized. The client is only closed when the ThreadSafeNucleiEngine is closed.
So effectively it would be safe to use interactsh opt in NewThreadSafeNucleiEngineCtx() but not in ExecuteNucleiWithOptsCtx().

The same tweak might apply to NetworkConfig, if I could use it to set the baseOpts when NewThreadSafeNucleiEngineCtx() is called and not allow using it when ExecuteNucleiWithOptsCtx() is called I think it would be safe?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
2 participants