Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make renderstate a class #241

Open
no-lex opened this issue Feb 2, 2022 · 0 comments
Open

Make renderstate a class #241

no-lex opened this issue Feb 2, 2022 · 0 comments
Assignees
@no-lex
Labels
misimplementation Circumlocutious or redundant implementation

Comments

@no-lex
Copy link
Member

no-lex commented Feb 2, 2022

renderstate is a data-only structure used for carrying around rendering data. However, it has a large number of associated functions which essentially act as member variables. Moving them into the renderstate object makes it clear what their association is. It is defined in renderva.cpp, and all of its associated functions are also located there.
@no-lex no-lex added the misimplementation Circumlocutious or redundant implementation label Feb 2, 2022
@no-lex no-lex self-assigned this Feb 2, 2022
no-lex added a commit that referenced this issue Nov 6, 2022
@no-lex
move changebatchtmus() to renderstate for #241
8bd9aa8
no-lex added a commit that referenced this issue Nov 6, 2022
@no-lex
move disablevquery() to renderstate for #241
01a1e4e
no-lex added a commit that referenced this issue Nov 6, 2022
@no-lex
move disablevbuf to renderstate for #241
8b884ba
no-lex added a commit that referenced this issue Nov 6, 2022
@no-lex
move enablevquery to renderstate for #241
434f13f
no-lex added a commit that referenced this issue Nov 6, 2022
@no-lex
add enablevquery signature to renderstate for #241
6aabf67
no-lex added a commit that referenced this issue Nov 8, 2022
@no-lex
move cleanupgeom() to renderstate for #241
f309e1c
no-lex added a commit that referenced this issue Nov 9, 2022
@no-lex
move disablevattribs() to renderstate for #241
e23a169
no-lex added a commit that referenced this issue Nov 9, 2022
@no-lex
move enablevattribs() to renderstate for #241
10e4d98
no-lex added a commit that referenced this issue Nov 13, 2022
@no-lex
make renderstate a class for #241
1f95e45
no-lex added a commit that referenced this issue Nov 13, 2022
@no-lex
use class keyword for renderstate (#241)
523976f
no-lex added a commit that referenced this issue Nov 15, 2022
@no-lex
move renderbatches to renderstate for #241
b53b651
no-lex added a commit that referenced this issue Nov 15, 2022
@no-lex
move changebatchtmus() to be private in renderstate for #241
fa3096e
no-lex added a commit that referenced this issue Nov 16, 2022
@no-lex
move changeslottmus() to renderstate for #241
bb257bc
no-lex added a commit that referenced this issue Nov 16, 2022
@no-lex
move bindslottex() to renderstate for #241
25e2c0d
no-lex added a commit that referenced this issue Nov 27, 2022
@no-lex
move changeshader() to renderstate for #241
e294c89
no-lex added a commit that referenced this issue Nov 28, 2022
@no-lex
move renderzpass to renderstate for #241
e6c3b54
no-lex added a commit that referenced this issue Feb 1, 2023
@no-lex
move texgen* variables to be private within renderstate for #241
41b3dbc
no-lex added a commit that referenced this issue Feb 1, 2023
@no-lex
move renderstate::alpha to private for #241
8703da4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@no-lex no-lex

Labels
misimplementation Circumlocutious or redundant implementation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@no-lex