Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(DA): restrict concurrency to avoid failures in tests #5005

Merged
merged 2 commits into from
May 29, 2024

Conversation

Jolg42
Copy link
Contributor

@Jolg42 Jolg42 commented May 29, 2024

We might be able to remove the restriction if we rework the tests.

To simplify: concurrency happens when 2 of the following happen: PR is open / merged or the update checked finds a new dev / latest / integration version.

Example failure:
https://github.com/prisma/ecosystem-tests/actions/runs/9287611832/job/25557871027?pr=5005#step:8:154

> turso-vercel-nextjs-edgemw@ test /home/runner/work/ecosystem-tests/ecosystem-tests/driver-adapters-wasm/turso-vercel-nextjs-edgemw
> jest index.test.js

FAIL ./index.test.js (10.28 s)
  ✕ prisma version and output (9954 ms)

  ● prisma version and output

    expect(received).toEqual(expected) // deep equality

    - Expected  - 1
    + Received  + 5

      Object {
    -   "error": "Transaction API error: Transaction already closed: Could not perform operation.",
    +   "error": "
    + Invalid `prisma.user.createMany()` invocation:
    +
    +
    + SQLITE_CONSTRAINT: SQLite error: UNIQUE constraint failed: User.email",
      }

We might be able to remove the restriction if we rework the tests.
.github/workflows/test.yaml Outdated Show resolved Hide resolved
@Jolg42 Jolg42 marked this pull request as ready for review May 29, 2024 14:27
@Jolg42 Jolg42 requested review from janpio, SevInf and jkomyno as code owners May 29, 2024 14:27
@Jolg42 Jolg42 merged commit dc2febe into dev May 29, 2024
@Jolg42 Jolg42 deleted the joel/restrict-concurrency-for-da branch May 29, 2024 14:28
@Jolg42 Jolg42 added this to the 5.15.0 milestone May 29, 2024
@Jolg42
Copy link
Contributor Author

Jolg42 commented May 29, 2024

Another example
https://github.com/prisma/ecosystem-tests/actions/runs/9286333431/job/25555841669#step:8:247

    +   "error": "
    + Invalid `prisma.user.update()` invocation:
    +
    +
    + An operation failed because it depends on one or more records that were required but not found. Record to update not found.",
      }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant