Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vercel-with-redwood): update expectation to OpenSSL 3.x engine #4697

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

Jolg42
Copy link
Contributor

@Jolg42 Jolg42 commented Mar 19, 2024

Example failure
https://github.com/prisma/ecosystem-tests/actions/runs/8340793087

https://vercel.com/prisma-orm/e2e-vercel-with-redwood/settings shows that the Node.js version is 18.x

It used to pass until 5.12.0-dev.14 (4 days ago)
Logs https://github.com/prisma/ecosystem-tests/actions/runs/8298730372/job/22712899025#step:8:329

 2024-03-15T15:42:25.990Z  prisma:get-platform Found distro info:
2024-03-15T15:42:25.991Z  {
2024-03-15T15:42:25.991Z    "targetDistro": "rhel",
2024-03-15T15:42:25.991Z    "familyDistro": "rhel",
2024-03-15T15:42:25.991Z    "originalDistro": "amzn"
2024-03-15T15:42:25.991Z  } +289ms
2024-03-15T15:42:25.991Z  prisma:get-platform Trying platform-specific paths for "rhel" +0ms
2024-03-15T15:42:25.992Z  prisma:get-platform Found libssl.so file using platform-specific paths: libssl.so.1.0.2k +2ms
2024-03-15T15:42:25.992Z  prisma:get-platform The parsed libssl version is: 1.0.x +0ms
2024-03-15T15:42:25.993Z  prisma:client:engines:resolveEnginePath enginePath /vercel/path0/node_modules/.prisma/client/libquery_engine-rhel-openssl-1.0.x.so.node +1ms

And now fails since 5.12.0-dev.15 (yesterday)
Logs: https://github.com/prisma/ecosystem-tests/actions/runs/8324738211/job/22777110892#step:8:341

 2024-03-18T10:16:10.018Z  prisma:get-platform Found distro info:
2024-03-18T10:16:10.018Z  {
2024-03-18T10:16:10.018Z    "targetDistro": "rhel",
2024-03-18T10:16:10.018Z    "familyDistro": "rhel",
2024-03-18T10:16:10.019Z    "originalDistro": "amzn"
2024-03-18T10:16:10.019Z  } +263ms
2024-03-18T10:16:10.019Z  prisma:get-platform Trying platform-specific paths for "rhel" +1ms
2024-03-18T10:16:10.019Z  prisma:get-platform Found libssl.so file using platform-specific paths: libssl.so.3 +1ms
2024-03-18T10:16:10.019Z  prisma:get-platform The parsed libssl version is: 3.0.x +1ms
2024-03-18T10:16:10.020Z  prisma:client:engines:resolveEnginePath enginePath /vercel/path0/node_modules/.prisma/client/libquery_engine-rhel-openssl-3.0.x.so.node +1ms

So this shows that the runtime changed, we didn't change anything in the logic on our side.

@Jolg42 Jolg42 added this to the 5.12.0 milestone Mar 19, 2024
@Jolg42
Copy link
Contributor Author

Jolg42 commented Mar 19, 2024

Actually, it might be linked to the Vercel CLI update I think, though I won’t try it to confirm at the moment
#4679

v33.6.1

Compare Source
Patch Changes

Don't send projectSettings.nodeVersion for unsupported versions ([#​11277](https://togithub.com/vercel/vercel/pull/11277))

Updated dependencies [[4bca0c6d0](https://togithub.com/vercel/vercel/commit/4bca0c6d0bc25052b95bd02b12a0b891c86c4b49), [a67ad4b5a](https://togithub.com/vercel/vercel/commit/a67ad4b5a130bf0e56e18111b3f9ddad69cec0e1), [11218a179](https://togithub.com/vercel/vercel/commit/11218a179870a5420c5a6ff720cd4aec4f7e1c5e), [64b97bf4b](https://togithub.com/vercel/vercel/commit/64b97bf4b5203ecf9a95f63ce26a5c3360208966)]:
    [@​vercel/next](https://togithub.com/vercel/next)[@​4](https://togithub.com/4).1.6
    [@​vercel/remix-builder](https://togithub.com/vercel/remix-builder)[@​2](https://togithub.com/2).1.4
    [@​vercel/build-utils](https://togithub.com/vercel/build-utils)[@​7](https://togithub.com/7).9.1
    [@​vercel/static-build](https://togithub.com/vercel/static-build)[@​2](https://togithub.com/2).4.4
    [@​vercel/node](https://togithub.com/vercel/node)[@​3](https://togithub.com/3).0.24

v33.6.0

Compare Source
Minor Changes

Set projectSettings.nodeVersion in vc deploy based on "engines.node" field ([#​11261](https://togithub.com/vercel/vercel/pull/11261))

Patch Changes

Stops warning about legacy Speed Insights for Next.js apps ([#​11268](https://togithub.com/vercel/vercel/pull/11268))

Fix framework version detection in monorepos ([#​11212](https://togithub.com/vercel/vercel/pull/11212))

Updated dependencies [[8ea93839c](https://togithub.com/vercel/vercel/commit/8ea93839ccc70816f3ece9d7cfdb857aa7a4b015), [58ef91bfe](https://togithub.com/vercel/vercel/commit/58ef91bfe8c2e7176e8783cc4eb91ee8580c70dc)]:
    [@​vercel/build-utils](https://togithub.com/vercel/build-utils)[@​7](https://togithub.com/7).9.0
    [@​vercel/remix-builder](https://togithub.com/vercel/remix-builder)[@​2](https://togithub.com/2).1.3
    [@​vercel/node](https://togithub.com/vercel/node)[@​3](https://togithub.com/3).0.23
    [@​vercel/static-build](https://togithub.com/vercel/static-build)[@​2](https://togithub.com/2).4.3

@Jolg42 Jolg42 self-assigned this Mar 19, 2024
@Jolg42 Jolg42 merged commit 12d12b7 into dev Mar 22, 2024
43 checks passed
@Jolg42 Jolg42 deleted the joel/vercel-with-redwood-fix branch March 22, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants