Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Make DIRECT_URL naming consistent with the previous pattern #5612

Closed
wants to merge 1 commit into from

Conversation

kof
Copy link

@kof kof commented Feb 2, 2024

Describe this PR

Current naming makes a mess in any env, because DIRECT_URL doesn't tell what that is, at the very least it has to stay consistent with the previous pattern, in ideal case both will be renamed because they are semantically wrong.

Changes

More consistent env variable naming

What issue does this fix?

Now people are copying bad naming and getting "DIRECT_URL" as a global env variable which says nothing about its usage and isn't consistent with Prisma's other url

Current naming makes a mess in any env, because DIRECT_URL doesn't tell what that is, at the very least it has to stay consistent with the previous pattern, in ideal case both will be renamed because they are semantically wrong.
Copy link

vercel bot commented Feb 2, 2024

@kof is attempting to deploy a commit to the Prisma Team on Vercel.

A member of the Team first needs to authorize it.

@kof kof changed the title Make DIRECT_URL naming consistent with the previous pattern docs: Make DIRECT_URL naming consistent with the previous pattern Feb 2, 2024
@jharrell
Copy link
Member

Hi there! Thank you very much for the contribution 🙏

Unfortunately, I don't think we'll be able to include this. While you're correct, DATABASE_DIRECT_URL is a more clear variable, we have several years of content pointing to the current setup of DATABASE_URL and DIRECT_URL.

Again, thank you very much, and I'll also bring notes back to our team to consider this naming change in the future.

@jharrell jharrell closed this Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants