Skip to content
This repository has been archived by the owner on Jun 12, 2018. It is now read-only.

Routing table dispatcher loses messages on Riak errors. #1131

Open
hodgestar opened this issue Dec 24, 2014 · 4 comments
Open

Routing table dispatcher loses messages on Riak errors. #1131

hodgestar opened this issue Dec 24, 2014 · 4 comments

Comments

@hodgestar
Copy link
Contributor

Unhandled errors in the routing table dispatcher fall through to default_errback (https://github.com/praekelt/vumi/blob/develop/vumi/dispatchers/endpoint_dispatchers.py#L56-L57). This logs the error and then acks the message to rabbit, causing the message to be marked and processed and logged. I propose that we implement a custom default_errback for the routing table dispatcher that logs the error and then re-raises it so that the message is not acked and returned to the Rabbit queue.

This is similar to what happened with the billing dispatcher recently (although that was addressed in a different way).

@hodgestar
Copy link
Contributor Author

@jerith @rudigiesler @justinvdm -- thoughts?

@jerith
Copy link
Member

jerith commented Dec 24, 2014

Sounds reasonable.

@justinvdm
Copy link
Contributor

+1, surprised that I haven't heard about this biting us before though.

@jerith
Copy link
Member

jerith commented Dec 24, 2014

We haven't had very many errors of this sort in the past.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants