New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pyOpenSci review] exclude TYPE_CHECKING statement from coverage report #547

Closed

rich-iannone opened this issue Dec 2, 2024 · 1 comment · Fixed by #556

Labels

pyOpenSci Review

Member

rich-iannone commented Dec 2, 2024

From the pyOpenSci review:

In the code, there is some code using the if TYPE_CHECKING statement. This could be excluded from the coverage report since this is False at runtime.

pyOpenSci/software-submission#202 (comment)

rich-iannone added the pyOpenSci Review label

Member Author

rich-iannone commented Dec 9, 2024

There's a possible global solution here: nedbat/coveragepy#831 (comment)

rich-iannone mentioned this issue

chore: exclude if TYPE_CHECKING: lines from coverage reporting #556

Merged

machow closed this as completed in #556

rich-iannone mentioned this issue

Great Tables submission pyOpenSci/software-submission#202

Open

31 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment