Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different implementations use sha256 or sha512 #21

Closed
0xbok opened this issue May 8, 2023 · 0 comments · Fixed by #26
Closed

Different implementations use sha256 or sha512 #21

0xbok opened this issue May 8, 2023 · 0 comments · Fixed by #26

Comments

@0xbok
Copy link

0xbok commented May 8, 2023

Circom and js use sha256.
Rust implementations use sha512.

So these implementations are not compatible.

I suggest passing all these implementations through a common test to ensure consistency.

@0xbok 0xbok changed the title Different implementations use sha256 or sh512 Different implementations use sha256 or sha512 May 8, 2023
@vuvoth vuvoth mentioned this issue May 12, 2023
4 tasks
@Divide-By-0 Divide-By-0 linked a pull request May 14, 2023 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant