From fa7e00257c2319201914d8bc799801b226c1a1dc Mon Sep 17 00:00:00 2001
From: RajeshRk18 <kannar432@gmail.com>
Date: Tue, 21 Nov 2023 01:16:35 +0530
Subject: [PATCH] fix binary decomposition

---
 circuits/circom/verify_nullifier.circom | 16 +++++++++++-----
 1 file changed, 11 insertions(+), 5 deletions(-)

diff --git a/circuits/circom/verify_nullifier.circom b/circuits/circom/verify_nullifier.circom
index ed43d0d..bf50d6d 100644
--- a/circuits/circom/verify_nullifier.circom
+++ b/circuits/circom/verify_nullifier.circom
@@ -29,7 +29,7 @@ template plume_v1(n, k, message_length) {
     signal input q1_x_mapped[4];
     signal input q1_y_mapped[4];
 
-    // compressing public key here to avoid compressing it twice in both `check_ec_equations1 and `sha256_12_coordinates`
+    // compressing public key here to avoid compressing it twice in both `check_ec_equations` and `sha256_12_coordinates`
     component pk_compressor = compress_ec_point(n, k);
     pk_compressor.uncompressed <== pk;
 
@@ -40,7 +40,8 @@ template plume_v1(n, k, message_length) {
 
     check_ec_equations.c <== c;
     check_ec_equations.s <== s;
-    check_ec_equations.pk <== pk_compressor.compressed;
+    check_ec_equations.pk <== pk;
+    check_ec_equations.pk_compressed <== pk_compressor.compressed;
     check_ec_equations.nullifier <== nullifier;
 
     check_ec_equations.plume_message <== plume_message;
@@ -126,6 +127,7 @@ template plume_v2(n, k, message_length) {
 
     check_ec_equations.c <== c;
     check_ec_equations.s <== s;
+    check_ec_equations.pk <== pk;
     check_ec_equations.pk_compressed <== pk_compressor.compressed;
     check_ec_equations.nullifier <== nullifier;
 
@@ -151,6 +153,7 @@ template check_ec_equations(n, k, message_length) {
     signal input c[k];
     signal input s[k];
     signal input plume_message[message_length];
+    signal input pk[2][k];
     signal input pk_compressed[33];
     signal input nullifier[2][k];
 
@@ -182,7 +185,7 @@ template check_ec_equations(n, k, message_length) {
 
     component r_point_comp = a_div_b_pow_c(n, k);
     r_point_comp.a <== s_point.pubkey;
-    r_point_comp.b <== pk_compressed;
+    r_point_comp.b <== pk;
     r_point_comp.c <== c;
 
     // Calculate hash[m, pk]^r
@@ -278,12 +281,15 @@ template sha256_12_coordinates(n, k) {
     component binary[6*33];
     for (var i = 0; i < 6; i++) { // for each compressor
         for (var j = 0; j < 33; j++) { // for each byte
-            if (i == 1) {
+            if (i == 0) {
+                binary[33*i + j] = Num2Bits(8);
+                binary[33*i + j].in <== compressors[i].compressed[j];                
+            } else if (i == 1) {
                 binary[33*i + j] = Num2Bits(8);
                 binary[33*i + j].in <== pk_compressed[j];
             } else {
                 binary[33*i + j] = Num2Bits(8);
-                binary[33*i + j].in <== compressors[i].compressed[j];
+                binary[33*i + j].in <== compressors[i-1].compressed[j];
             }
         }
     }