Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem instantate BlockChain without domain-specific IActionEvalautor. #3977

Open
riemannulus opened this issue Oct 28, 2024 · 0 comments · May be fixed by #3978
Open

Problem instantate BlockChain without domain-specific IActionEvalautor. #3977

riemannulus opened this issue Oct 28, 2024 · 0 comments · May be fixed by #3978
Assignees
@riemannulus

Comments

@riemannulus
Copy link
Member

riemannulus commented Oct 28, 2024 •
edited
Loading

Context

libplanet/src/Libplanet/Blockchain/BlockChain.cs

Lines 193 to 199 in c1a1c5e

else
{
_nextStateRootHash =
DetermineNextBlockStateRootHash(Tip, out var actionEvaluations);
IEnumerable<TxExecution> txExecutions = MakeTxExecutions(Tip, actionEvaluations);
UpdateTxExecutions(txExecutions);
}

BlockChain.BlockChain must run IActionEvalautor.Execute() when initiated.
But when we want to open the BlockChain read-only version, Even though it is a non-domain-dependent class, it has domain-dependent dependencies.

Rationale

We need to add a boolean flag to BlockChain.BlockChain so the user can bypass the feature if the user doesn't want it.
@riemannulus riemannulus self-assigned this Oct 28, 2024
@riemannulus riemannulus linked a pull request Oct 28, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@riemannulus riemannulus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: execute states by condition planetarium/libplanet
1 participant
@riemannulus